Compiler: fix compiler_version.ml generation#113
Merged
hhugo merged 1 commit intoocsigen:masterfrom Mar 19, 2014
bnoordhuis:fix-compiler-build
Merged
Compiler: fix compiler_version.ml generation#113hhugo merged 1 commit intoocsigen:masterfrom bnoordhuis:fix-compiler-build
hhugo merged 1 commit intoocsigen:masterfrom
bnoordhuis:fix-compiler-build
Conversation
Remove the \n, it ends up as a literal "\\n" in the generated .ml file and subsequently breaks the build. Fixes a regression introduced in commit 4597761 and resolves the following build error: $ make -C compiler make: Entering directory `/home/bnoordhuis/src/js_of_ocaml/compiler' ocamlfind ocamlopt -package findlib,str -for-pack Compiler -c compiler_version.ml File "compiler_version.ml", line 1, characters 17-18: Error: Illegal character (\\) make: *** [compiler_version.cmx] Error 2 make: Leaving directory `/home/bnoordhuis/src/js_of_ocaml/compiler'
hhugo
added a commit
that referenced
this pull request
Mar 19, 2014
Compiler: fix compiler_version.ml generation
vouillon
added a commit
to OlivierNicole/js_of_ocaml
that referenced
this pull request
Nov 26, 2024
Some optimizations were no longer applied after the array initialization fix in ocsigen#113. The following functions from `Js.Unsafe` were affected: `call`, `fun_call`, `meth_call` and `new_obj`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the \n, it ends up as a literal "\n" in the generated .ml file
and subsequently breaks the build.
Fixes a regression introduced in commit 4597761 and resolves the
following build error: