Could you explain a bit how this work (to someone not familiar with topfind)? My understanding is that the user willing to use topfind on a js_of_ocaml-using webpage should run the ./server program provided by the js_of_ocaml distribution on his/her machine, and that it will send any requested file to the js_of_ocaml webpage (in fact to ocamlfind scripts running, after compilation to JS, on from this webpage).

I'm wondering what the use-cases for this are; if I correctly understand that the user should run the server, it seems potentially useful but also much more limiting than classic js_of_ocaml (which doesn't require an OCaml installation).

In any case, I'm also curious about the security implications of having a program running on my machine ready to upload any file from my filesystem. Is there a risk of attack from malicious javascript injected in this webpage or another? Is there a risk of attack from outside localhost?

On Wed, Mar 19, 2014 at 4:26 PM, gasche notifications@github.com wrote:

Could you explain a bit how this work (for someone not familiar with
topfind?). My understanding is that the user willing to use topfind a
js_of_ocaml-using webpage should run the ./server program provided by the
js_of_ocaml distribution on his/her machine, and that it will send any
requested file to the js_of_ocaml webpage (in fact to ocamlfind scripts
running, after compilation to JS, on from this webpage).

Firstly this feature is primarily for the js_of_ocaml toplevel and not so
much for arbitrary js_of_ocaml applications.

It doesn't actually require ocamlfind; normal ocaml directives like #load
also work as will functions like open_in as it uses the js_of_ocaml psuedo
filesystem at quite a low level.

I'm wondering what the use-cases for this are; if I correctly understand

that the user should run the server, it seems potentially useful but also
much more limiting than classic js_of_ocaml (which doesn't require an OCaml
installation).

It might perhaps find use with developers who want to test their libraries
interactively with the js_of_ocaml toplevel without building an application.

I don't think it changes any other use case of js_of_ocaml.

In any case, I'm also curious about the security implications of having a

program running on my machine ready to upload any file from my filesystem.
Is there a risk of attack from malicious javascript injected in this
webpage or another? Is there a risk of attack from outside localhost?

It should only serve files on 127.0.0.1:8888 so I don't think it's possible
to access it from outside. Certainly you could configure things to allow
that and you would want to be very careful in that case.

Files should only be accessible from $(HOME)/.opam but I note that you can
subvert that with paths like "$(HOME)/.opam/../" which should probably be
fixed

-Andy

Reply to this email directly or view it on GitHubhttps://github.com//pull/111#issuecomment-38072703
.