tests/test_long_collection_name.py (6)

16-28: Parameter input shadows Python built-in.

The parameter name input shadows the built-in function. Consider renaming to texts or documents for clarity.

Also note that hash() is not deterministic across Python runs unless PYTHONHASHSEED is set. This is acceptable here since embedding values aren't asserted, but worth documenting if reused elsewhere.

---

48-60: Missing client cleanup after yield.

The fixture yields the client but doesn't perform cleanup. If pyseekdb.Client holds connections or resources, they may leak.

♻️ Add cleanup after yield

     `@pytest.fixture`
     def server_client(self):
         """Create server mode client"""
         import pyseekdb
         client = pyseekdb.Client(
             host=self.SERVER_HOST,
             port=self.SERVER_PORT,
             tenant="sys",
             database=self.SERVER_DATABASE,
             user=self.SERVER_USER,
             password=self.SERVER_PASSWORD
         )
         yield client
+        # Cleanup: close client connection if method exists
+        if hasattr(client, 'close'):
+            client.close()

---

62-79: Cleanup may be skipped if assertion fails.

If the assertion on line 74 fails, the collection won't be deleted, potentially leaving test artifacts. Consider using try/finally or addCleanup.

Also, line 79 has an f-string without placeholders (per static analysis).

♻️ Proposed fix with guaranteed cleanup

     def test_create_collection_with_long_name(self, server_client):
         """Test create collection with name > 64 chars"""
         print("\n" + "="*60)
         print("Testing create collection with long names (>64 chars)")
         print("="*60)
 
         for name in self.LONG_NAMES:
             print(f"\n✅ Creating collection with name length: {len(name)}")
-            collection = server_client.create_collection(
-                name=name,
-                embedding_function=Simple3DEmbeddingFunction()
-            )
-            assert collection.name == name, f"Collection name mismatch: {collection.name} != {name}"
-            print(f"   Created successfully: {name[:50]}...")
-
-            # Cleanup
-            server_client.delete_collection(name=name)
-            print(f"   Deleted successfully")
+            try:
+                collection = server_client.create_collection(
+                    name=name,
+                    embedding_function=Simple3DEmbeddingFunction()
+                )
+                assert collection.name == name, f"Collection name mismatch: {collection.name} != {name}"
+                print(f"   Created successfully: {name[:50]}...")
+            finally:
+                # Cleanup regardless of assertion result
+                if server_client.has_collection(name=name):
+                    server_client.delete_collection(name=name)
+                    print("   Deleted successfully")

---

111-137: Same cleanup concern; multiple f-strings without placeholders.

If the assertion on line 128 fails, the collection remains. Consider wrapping in try/finally.

Static analysis flags f-strings without placeholders on lines 125, 129, 133, 137. These should be regular strings.

♻️ Fix f-strings

-        print(f"   Created collection")
+        print("   Created collection")
 
         # Verify exists
         assert server_client.has_collection(name=name)
-        print(f"   Verified collection exists")
+        print("   Verified collection exists")
 
         # Delete
         server_client.delete_collection(name=name)
-        print(f"   Deleted successfully")
+        print("   Deleted successfully")
 
         # Verify deleted
         assert not server_client.has_collection(name=name)
-        print(f"   Verified collection deleted")
+        print("   Verified collection deleted")

---

163-171: Minor: f-string without placeholder on line 167.

Line 167 uses f-string but has no placeholders. Use a regular string.

-    print(f"\nEnvironment Configuration:")
+    print("\nEnvironment Configuration:")

---

35-39: Optional: Annotate mutable class attribute with ClassVar.

Per static analysis (RUF012), mutable class attributes should be annotated. The fullwidth parentheses in Chinese comments (RUF003) are acceptable for readability.

+from typing import ClassVar, List, Union
+
 class TestLongCollectionName:
-    LONG_NAMES = [
+    LONG_NAMES: ClassVar[list[str]] = [
         "a" * 65,
         "b" * 128,
         "c" * 512,
     ]