fix for 4.07: Ident.t is now an abstract type#24
Merged
whitequark merged 1 commit intoocaml-ppx:masterfrom Jun 8, 2018
Merged
Conversation
Closed
Contributor
|
The travis CI fails on 4.02 and 4.03, apparently due to an incompatibility between the upstream opam repository and the opam version that the CI instances use. I am testing locally that the build still work on these version, then merging. |
Contributor
|
Apparently I can't merge in this repository (maybe because the CI failed?), but I was able to test that this PR builds fine under 4.03.0. |
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Nov 10, 2018
CHANGES: 1.6 --- * ocaml-migrate-parsetree + dune support ocaml-ppx/ppx_import#26 (Jérémie Dimino & Emilio Jesús Gallego Arias) * Move to OPAM 2.0, adapt Travis CI. (Emilio Jesús Gallego Arias) 1.5 --- * OCaml 4.07 support ocaml-ppx/ppx_import#24 (Damien Doligez) * Call the type-checker (through compiler-libs) instead of reading `.cmi` files directly, to correctly resolve module aliases. ocaml-ppx/ppx_import#25 (Gabriel Scherer) 1.4 --- * OCaml 4.06 support ocaml-ppx/ppx_import#19 (Gabriel Scherer) 1.3 --- * Also allow extraction of module types from the current module's interface file. ocaml-ppx/ppx_import#12 (Xavier Guérin) 1.2 --- * Allow extracting types from the current module's interface file. (Xavier Guérin) 1.1 --- * OCaml 4.03 support. (whitequark) 1.0 --- * Allow extracting types from module types. (whitequark) 0.1 --- * Initial release. (whitequark)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the non-problematic part extracted from #23
cc @gasche