Define a vendored Compat library to be compatible with base.v0.14.0#1396
Define a vendored Compat library to be compatible with base.v0.14.0#1396gpetiot merged 5 commits intoocaml-ppx:masterfrom gpetiot:vendor-utils-lib
Conversation
|
I realize that this is a small patch, but I have to say that I don't think that the basic approach is a good long-term solution. In particular, I do not think that we should complicate the code (other than a clearly designated compatibility module/library). Things like needing to remember which
|
|
Why not avoid depending on base/stdio? |
|
Because we already are deeply depending on this (kinda too late), removing it would require a huge amount of work that would better be directed towards fixing bugs and improving the integration of ocamlformat with the rest of the ocaml tools. |
CHANGES:
#### Changes
+ No functional changes from 0.14.2. The goal of this release is to be
compatible with base and stdio v0.14.0.
+ Backport the following PRs:
- ocaml-ppx/ocamlformat#1386 - Update opam metadata
- ocaml-ppx/ocamlformat#1396 - Add compatibility with base.v0.14.0
- ocaml-ppx/ocamlformat#1399 - Allow stdio.v0.14
We could also put the library extensions ofFpathandCmdlinerthat are defined inlib/import/Import.mlinutilsas welledit: renamed as Compat, so it doesn't make as much sense
I removed the copyright headers since the code is vendored