Revert deprecation of doc-comments#1331
Merged
Julow merged 3 commits intoocaml-ppx:masterfrom Apr 14, 2020
Merged
Conversation
This was done too fast, alternatives weren't tested on real projects and users.
gpetiot
approved these changes
Apr 14, 2020
Collaborator
gpetiot
left a comment
There was a problem hiding this comment.
Minor comment on the changelog, otherwise looks good to me, thanks.
gpetiot
approved these changes
Apr 14, 2020
Julow
added a commit
to Julow/opam-repository
that referenced
this pull request
Apr 14, 2020
CHANGES: #### Changes + The default for `doc-comments` is changed to `after` (ocaml-ppx/ocamlformat#1335) (Jules Aguillon) This reverts a change introduced in 0.14.0 (ocaml-ppx/ocamlformat#1012). + Revert deprecation of the `doc-comments` option (ocaml-ppx/ocamlformat#1331) (Jules Aguillon) This reverts a change introduced in 0.14.0 (ocaml-ppx/ocamlformat#1293).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done too fast, alternatives weren't tested on real projects and users.
This caused some problems, Owl is explicitly using the deprecated option and Irmin won't upgrade. This may also cause huge diffs on Infer.