Remove load-time argv parsing#1148
Merged
emillon merged 1 commit intoocaml-ppx:masterfrom Nov 14, 2019
Merged
Conversation
`Conf.action` had side effects as it immediately parsed `Sys.argv` at load time. This has to be delayed so that we can link the lib in a test suite for example.
66135e1 to
33d738e
Compare
Julow
reviewed
Nov 14, 2019
Collaborator
Julow
left a comment
There was a problem hiding this comment.
That's a good idea but we need more ! We should move that part of Conf into an other module, so that Conf API is smaller and better defined and can then be documented and tested more easily.
Collaborator
Author
|
This is the part that blocks linking, the rest can be improved later. |
Collaborator
Author
|
Thanks ! |
This was referenced Nov 19, 2019
bogdan2412
pushed a commit
to bogdan2412/ocamlformat
that referenced
this pull request
Mar 28, 2020
`Conf.action` had side effects as it immediately parsed `Sys.argv` at load time. This has to be delayed so that we can link the lib in a test suite for example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conf.actionhad side effects as it immediately parsedSys.argvat load time. This has to be delayed so that we can link the lib in a test suite for example.