Skip to content
This repository was archived by the owner on Jun 21, 2024. It is now read-only.

Bring root management of backtrace_last_exn in systhreads closer to trunk#771

Merged
kayceesrk merged 1 commit into5.00from
bt_last_exn_systhreads
Dec 6, 2021
Merged

Bring root management of backtrace_last_exn in systhreads closer to trunk#771
kayceesrk merged 1 commit into5.00from
bt_last_exn_systhreads

Conversation

@kayceesrk
Copy link
Copy Markdown
Contributor

Removes the use of generational roots. Fixes #770.

@abbysmal
Copy link
Copy Markdown
Collaborator

abbysmal commented Dec 6, 2021

This change looks good to me.
I wonder if there were any specific reason for us going with generational global roots? I remember we did switch them a while back when we aligned with the removal of the caml_root API, but I'm not sure why we went with generational here.
Nonetheless the change is good and I think we can merge it.

@kayceesrk
Copy link
Copy Markdown
Contributor Author

Looks like I'd changed it to caml_root in [1] as part of the large change to get systhreads working. But this was not necessary.

[1] 0c581a5#diff-6bc1eb5d8edb8bd3593546c93ab7f58de42768b3941731da9f2b00d3652b3d87R82

@kayceesrk kayceesrk merged commit d286c20 into 5.00 Dec 6, 2021
@kayceesrk kayceesrk mentioned this pull request Dec 10, 2021
sadiqj pushed a commit to sadiqj/ocaml that referenced this pull request Jan 10, 2022
…ticore/bt_last_exn_systhreads

Bring root management of backtrace_last_exn in systhreads closer to trunk
ctk21 pushed a commit to ctk21/ocaml that referenced this pull request Jan 11, 2022
…ticore/bt_last_exn_systhreads

Bring root management of backtrace_last_exn in systhreads closer to trunk
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segfault using domains and effects together

2 participants