This repository was archived by the owner on Jun 21, 2024. It is now read-only.
Modernise signal handling (ocaml#9543)#584
Merged
sadiqj merged 1 commit intoocaml-multicore:4.12+domains+effectsfrom Jul 9, 2021
Merged
Modernise signal handling (ocaml#9543)#584sadiqj merged 1 commit intoocaml-multicore:4.12+domains+effectsfrom
sadiqj merged 1 commit intoocaml-multicore:4.12+domains+effectsfrom
Conversation
…ignals_nat.c vs upstream; pick up changes in ocaml#9543
sadiqj
approved these changes
Jun 18, 2021
Collaborator
sadiqj
left a comment
There was a problem hiding this comment.
I think this is fine. There are a few things that are no longer relevant on trunk (young limit is no longer cached) but this brings us pretty close to 4.12 on trunk and we can deal with those in the rebase.
It might be worth us at least checking this builds on Windows.
Merged
Collaborator
|
Took a look and it LGTM. |
sadiqj
added a commit
to sadiqj/ocaml
that referenced
this pull request
Jan 10, 2022
…row_gap_upstream_signals Modernise signal handling (ocaml#9543)
c-cube
pushed a commit
to c-cube/ocaml
that referenced
this pull request
Feb 3, 2022
…row_gap_upstream_signals Modernise signal handling (ocaml#9543)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports ocaml#9543 to ocaml-multicore, bringing the multicore signals implementation a little closer to upstream.
In particular this makes things a bit easier when doing a diff of multicore vs upstream for signals.