Skip to content

Eio.Net: add getnameinfo#288

Merged
talex5 merged 1 commit intoocaml-multicore:mainfrom
bikallem:getnameinfo
Aug 25, 2022
Merged

Eio.Net: add getnameinfo#288
talex5 merged 1 commit intoocaml-multicore:mainfrom
bikallem:getnameinfo

Conversation

@bikallem
Copy link
Copy Markdown
Contributor

No description provided.

@bikallem bikallem requested a review from talex5 August 23, 2022 09:01
@bikallem
Copy link
Copy Markdown
Contributor Author

@talex5 I have removed ni_dgram from the API. Since luv doesn't support getnameinfo on UNIX domain, we now use Eio_unix.getnameinfo on both uring and luv backends.

Copy link
Copy Markdown
Collaborator

@talex5 talex5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@talex5 talex5 merged commit 0984588 into ocaml-multicore:main Aug 25, 2022
@bikallem bikallem deleted the getnameinfo branch August 25, 2022 09:10
talex5 added a commit to talex5/opam-repository that referenced this pull request Aug 26, 2022
CHANGES:

New features:

- Add `Eio.Condition` (@TheLortex @talex5 ocaml-multicore/eio#277).
  Allows a fiber to wait for some condition to become true.

- Add `Eio.Net.getaddrinfo` and `getnameinfo` (@bikallem @talex5 ocaml-multicore/eio#278 ocaml-multicore/eio#288 ocaml-multicore/eio#291).
  Convert between host names and addresses.

- Add `Eio.Debug` (@talex5 ocaml-multicore/eio#276).
  Currently, this allows overriding the `traceln` function.

- `Buf_write.create`: make switch optional (@talex5 ocaml-multicore/eio#283).
  This makes things easier for people porting code from Faraday.

Bug fixes:

- Allow sharing of libuv poll handles (@patricoferris @talex5 ocaml-multicore/eio#279).
  Luv doesn't allow two callers to watch the same file handle, so we need to handle that in Eio.

Other changes:

- Upgrade to uring 0.4 (@talex5 ocaml-multicore/eio#290).

- Mention `Mutex`, `Semaphore` and `Condition` in the README (@talex5 ocaml-multicore/eio#281).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants