Do not allow close on accept_fork socket#245
Merged
talex5 merged 1 commit intoocaml-multicore:mainfrom Jul 1, 2022
Merged
Conversation
`accept_fork` closes the socket when the function returns. Prevent the function from trying to close the socket itself. Fixes ocaml-multicore#244.
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Aug 4, 2022
CHANGES: Note: Eio 0.4 drops compatibility with OCaml 4.12+domains. Use OCaml 5.0.0~alpha1 instead. API changes: - `Eio.Dir` has gone. Use `Eio.Path` instead (@talex5 ocaml-multicore/eio#266 ocaml-multicore/eio#270). - `Eio_unix.FD.{take,peek}` were renamed to `take_opt`/`peek_opt` to make way for non-optional versions. New features: - Fiber-local storage (@SquidDev ocaml-multicore/eio#256). Attach key/value bindings to fibers. These are inherited across forks. - `Eio.Path.{unlink,rmdir,rename}` (@talex5 ocaml-multicore/eio#264 ocaml-multicore/eio#265). - `Eio_main.run` can now return a value (@talex5 ocaml-multicore/eio#263). This is useful for e.g. cmdliner. - `Eio_unix.socketpair` (@talex5 ocaml-multicore/eio#260). - `Fiber.fork_daemon` (@talex5 ocaml-multicore/eio#252). Create a helper fiber that does not prevent the switch from exiting. - Add `Fiber.{iter,map,filter,fiter_map}` (@talex5 ocaml-multicore/eio#248 ocaml-multicore/eio#250). These are concurrent versions of the corresponding operations in `List`. Bug fixes: - Fix scheduling fairness in luv backend (@talex5 ocaml-multicore/eio#269). - Implement remaining shutdown commands for luv (@talex5 ocaml-multicore/eio#268). - Fix IPv6 support with uring backend (@haesbaert ocaml-multicore/eio#261 ocaml-multicore/eio#262). - Use `Eio.Net.Connection_reset` exception in more places (@talex5 ocaml-multicore/eio#257). - Report use of closed FDs better (@talex5 ocaml-multicore/eio#255). Using a closed FD could previously cause the whole event loop to exit. - Some fixes for cancellation (@talex5 ocaml-multicore/eio#254). - Ensure `Buf_write` still flushes if an exception is raised (@talex5 ocaml-multicore/eio#246). - Do not allow close on `accept_fork` socket (@talex5 ocaml-multicore/eio#245). Documentation: - Document integrations with Unix, Lwt and Async (@talex5 ocaml-multicore/eio#247). - Add a Dockerfile for easy testing (@talex5 ocaml-multicore/eio#224).
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Aug 4, 2022
CHANGES: Note: Eio 0.4 drops compatibility with OCaml 4.12+domains. Use OCaml 5.0.0~alpha1 instead. API changes: - `Eio.Dir` has gone. Use `Eio.Path` instead (@talex5 ocaml-multicore/eio#266 ocaml-multicore/eio#270). - `Eio_unix.FD.{take,peek}` were renamed to `take_opt`/`peek_opt` to make way for non-optional versions. New features: - Fiber-local storage (@SquidDev ocaml-multicore/eio#256). Attach key/value bindings to fibers. These are inherited across forks. - `Eio.Path.{unlink,rmdir,rename}` (@talex5 ocaml-multicore/eio#264 ocaml-multicore/eio#265). - `Eio_main.run` can now return a value (@talex5 ocaml-multicore/eio#263). This is useful for e.g. cmdliner. - `Eio_unix.socketpair` (@talex5 ocaml-multicore/eio#260). - `Fiber.fork_daemon` (@talex5 ocaml-multicore/eio#252). Create a helper fiber that does not prevent the switch from exiting. - Add `Fiber.{iter,map,filter,fiter_map}` (@talex5 ocaml-multicore/eio#248 ocaml-multicore/eio#250). These are concurrent versions of the corresponding operations in `List`. Bug fixes: - Fix scheduling fairness in luv backend (@talex5 ocaml-multicore/eio#269). - Implement remaining shutdown commands for luv (@talex5 ocaml-multicore/eio#268). - Fix IPv6 support with uring backend (@haesbaert ocaml-multicore/eio#261 ocaml-multicore/eio#262). - Use `Eio.Net.Connection_reset` exception in more places (@talex5 ocaml-multicore/eio#257). - Report use of closed FDs better (@talex5 ocaml-multicore/eio#255). Using a closed FD could previously cause the whole event loop to exit. - Some fixes for cancellation (@talex5 ocaml-multicore/eio#254). - Ensure `Buf_write` still flushes if an exception is raised (@talex5 ocaml-multicore/eio#246). - Do not allow close on `accept_fork` socket (@talex5 ocaml-multicore/eio#245). Documentation: - Document integrations with Unix, Lwt and Async (@talex5 ocaml-multicore/eio#247). - Add a Dockerfile for easy testing (@talex5 ocaml-multicore/eio#224).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accept_forkcloses the socket when the function returns. Prevent the function from trying to close the socket itself. This removes theclosemethod from the socket type, which matches the situation with flows. Alternatively, we could just ignore multiple close attempts.Fixes #244.