Merged
Conversation
mshinwell
requested changes
Apr 7, 2020
middle_end/flambda2.0/from_lambda/lambda_to_flambda_primitives.ml
Outdated
Show resolved
Hide resolved
middle_end/flambda2.0/from_lambda/lambda_to_flambda_primitives.ml
Outdated
Show resolved
Hide resolved
middle_end/flambda2.0/from_lambda/lambda_to_flambda_primitives.ml
Outdated
Show resolved
Hide resolved
middle_end/flambda2.0/from_lambda/lambda_to_flambda_primitives.ml
Outdated
Show resolved
Hide resolved
Author
|
Reviews have been addressed, just waiting for a new review and CI to be green. |
Change the status of bigarray primitives: - bigarray_load is now a binary primitive - bigarray_store is now a ternary primitive Translation from multi-dimension addressing to linear addressing is done in the primitive translation, so that the bigarray primitives take a single linear offset. Adidtionally the unknwon variant for bigarray kind and layout in flambda2 are removed because theyr are translated into c-calls in prepare_lambda. Cmm code generation has been adapted. Better cache: Use subset comparison, as the functions are monotone
Author
|
Rebased because of the inlining_cost merge (and inlining costs have been adjusted for the new translation). |
lthls
pushed a commit
that referenced
this pull request
Sep 29, 2020
* Better bigarray primitives + liveness cache update Change the status of bigarray primitives: - bigarray_load is now a binary primitive - bigarray_store is now a ternary primitive Translation from multi-dimension addressing to linear addressing is done in the primitive translation, so that the bigarray primitives take a single linear offset. Adidtionally the unknwon variant for bigarray kind and layout in flambda2 are removed because theyr are translated into c-calls in prepare_lambda. Cmm code generation has been adapted. Better cache: Use subset comparison, as the functions are monotone * Update test list * Address reviews * Reviews * Adapt inlining costs for bigarray primitives * Better effects and coeffects for read and writes * Last reviews * Fix unused vars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bigarray primitives + some other related changes (see commit messages).