Strip whitespaces from the end of the metadata field#3
Merged
jonludlam merged 2 commits intoocaml-doc:mainfrom Dec 10, 2021
Merged
Strip whitespaces from the end of the metadata field#3jonludlam merged 2 commits intoocaml-doc:mainfrom
jonludlam merged 2 commits intoocaml-doc:mainfrom
Conversation
Spaces at this locations are not meant by the user to be data and require special handlings in tools like Mdx and OCamlformat.
Leonidas-from-XIV
approved these changes
Dec 10, 2021
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
This is exactly the change that I appreciate in MDX (since it free's me from stripping whitespace while making sure that other tools parsing odoc behave consistently) and as someone who would write odoc metadata (since I would not expect the whitespace to be meaningful)!
Collaborator
|
Thanks @Julow ! |
jonludlam
added a commit
to jonludlam/opam-repository
that referenced
this pull request
Dec 11, 2021
CHANGES: - New syntax to allow associating metadata with code blocks (@Julow, ocaml-doc/odoc-parser#2, ocaml-doc/odoc-parser#3)
jonludlam
pushed a commit
to jonludlam/odoc-parser
that referenced
this pull request
Feb 22, 2023
Fix default alignment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spaces at this locations are not meant by the user to be data and require special handlings in tools like Mdx and OCamlformat:
All should parse to the same AST.