ocaml-variants.4.11* and 4.12*: avoid passing CC and ASPP for FreeBSD#16575
Merged
avsm merged 1 commit intoocaml:masterfrom Jun 5, 2020
Merged
ocaml-variants.4.11* and 4.12*: avoid passing CC and ASPP for FreeBSD#16575avsm merged 1 commit intoocaml:masterfrom
avsm merged 1 commit intoocaml:masterfrom
Conversation
Contributor
|
Commit: 93b4509 A pull request by opam-seasoned @hannesm. 🌤️ opam-lint warnings 93b4509
☀️ Installability check (+0) |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Dec 5, 2020
… FreeBSD As done earlier (in ocaml#16575) and mentioned in ocaml#16568 (comment) this is no longer necessary since ocaml/ocaml#9437 - which was part of 4.11.0. NB: I'm not a big fan of modifying existing packages, but imho this is sane and safe in this case, and looking at ocaml#16575 it seemed to be fine with maintainers back then. I did not touch: - 32bit - flambda+musl - flambda+musl+static Since I don't understand how they are supposed to work in the first place. Eventually it'd make sense to restrict them to supported platforms via (available = [ os = "linux" & os-distribution = ... ])?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as mentioned in #16568 (comment), this is no longer needed (see ocaml/ocaml#9437).
tested locally, and it works (in Makefile.config,
cc -c -Wno-trigraphsis used as assembler). //cc @Octachronas mentioned earlier, I suspect this can be done for macos and openbsd as well, but I fail to have such a system for testing at hands (thus this PR only targets FreeBSD).