Merged
Conversation
1f42a63 to
79fb805
Compare
rjbou
reviewed
Dec 4, 2024
Contributor
rjbou
left a comment
There was a problem hiding this comment.
On the general idea, lgtm!
| lexer lexbuf | ||
| in | ||
| let result = | ||
| try with_clear_parser (main lexer lexbuf) file_name |
Contributor
There was a problem hiding this comment.
With menhir, there is no more need to clear the parser?
Member
Author
There was a problem hiding this comment.
no menhir doesn't use the internal states from Stdlib.Parsing so it would be pointless to call this function, and as far as i know it doesn't have an equivalent function.
| value: | ||
| value: valu_ EOF { $1 } | ||
|
|
||
| valu_: |
Contributor
There was a problem hiding this comment.
It's better to have value here, and rename value l.101
Member
Author
There was a problem hiding this comment.
discussed elsewhere: sadly value is required to be defined this way because it is the name of the value exported. I've added comments instead
Contributor
|
sounds good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR on top of #51
This PR changes the parser from ocamlyacc to menhir. I made this sit on top of #51 for simplicity sake.
If merged I believe we should release this as
opam-file-format.2.2.0