Remove the GNU Make build system in favour of Dune#51
Merged
kit-ty-kate merged 6 commits intoocaml:masterfrom Dec 4, 2024
Merged
Remove the GNU Make build system in favour of Dune#51kit-ty-kate merged 6 commits intoocaml:masterfrom
kit-ty-kate merged 6 commits intoocaml:masterfrom
Conversation
48dd208 to
c6b80d5
Compare
…nt on alcotest (uses check_raises)
c6b80d5 to
fed24f3
Compare
rjbou
reviewed
Dec 4, 2024
README.md
Outdated
| This library provides the parser and printer for the opam file syntax as a | ||
| library with no dependencies. The package can be built either with GNU make | ||
| or any version of [Dune](https://dune.build). | ||
| library with no dependencies but [Dune](https://dune.build) >= 1.3. |
Contributor
There was a problem hiding this comment.
Suggested change
| library with no dependencies but [Dune](https://dune.build) >= 1.3. | |
| library with no dependencies but [Dune](https://dune.build) >= 1.4. |
As part of the last commit
rjbou
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintaining a separate makefile on top of dune seems like a maintenance time sink as shown by e.g. #50 #41 #39
This PR makes is so dune becomes the only build system. If someone wish for this to not go through please comment with your concerns here. This is only an RFC for now.