Fix switch & repo format upgrade#6839
Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom Dec 22, 2025
Merged
Conversation
kit-ty-kate
approved these changes
Dec 18, 2025
Member
kit-ty-kate
left a comment
There was a problem hiding this comment.
lgtm modulo typo and green CI state on #6393 whenever it is rebased on top of this
… one Recreating the lock reopened the fd on the lock file causing a block when the write lock was taken.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen on #6393 (#6393 (comment)). The lock can't be acquired when opam want to write the new repo state on Windows. That was caused by taking a new
OpamSystem.lockon the lock file instead of reusing the already created one and update its system lock.Introduced in #5305, related to #6417