opam root version: fix upgrade from a non global config change#5305
opam root version: fix upgrade from a non global config change#5305dra27 merged 4 commits intoocaml:masterfrom
Conversation
0efc815 to
afbcb56
Compare
dra27
left a comment
There was a problem hiding this comment.
We're nearly there with this thorny thing! I have various notes to put back into the wiki on the root versions stuff.
src/format/opamFile.ml
Outdated
|
|
||
| let internal = "repos-config" | ||
| let format_version = OpamVersion.of_string "2.0" | ||
| let format_version = OpamVersion.of_string "2.1" |
There was a problem hiding this comment.
It would be better to bump it straight to 2.2, wouldn't it? (I think the "gap" is less confusing than having a 2.1 version of the format which technically can't be read by opam 2.1's libraries!)
There was a problem hiding this comment.
I don't remember what we say about those versions : should they follow opam versions ?
There was a problem hiding this comment.
I think the intention was that we'd use opam versions when it was bumped, yes - so it just so happened that opam 2.1 uses opam 2.0's repo config format
|
Updated |
Used to retrieve information about remaining upgrades to do (repo or switch)
When root is bumped but only repo or switch is modified, upgraded files can be written without writing the root bump (on-the-fly global state upgrade).
dra27
left a comment
There was a problem hiding this comment.
LGTM! (sorry for the delay re-reviewing)
No description provided.