logging: fix log file management for tests#6673
Merged
kit-ty-kate merged 1 commit intoocaml:masterfrom Sep 11, 2025
Merged
Conversation
c27ce61 to
75cb3f0
Compare
75cb3f0 to
1fd3d20
Compare
kit-ty-kate
reviewed
Sep 5, 2025
Member
kit-ty-kate
left a comment
There was a problem hiding this comment.
Negative values support for OPAMDEBUG was added in d59bf85. This behaviour isn't really documented (mostly used for ourselves anyway) and i personally didn't know about it.
I feel like, instead of using Stdlib.abs everywhere but the piece of code that needs it in OpamConsole, we should probably make it so that OpamCoreConfig.debug_level is always >= 0 and have a separate field to encode the sign. Something called OpamCoreConfig.repeatable_debug : bool or something to make it clearer.
Otherwise the rest of the changes are obviously correct.
1fd3d20 to
f241506
Compare
kit-ty-kate
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.