Skip to content

reftests: Clean some tests#6671

Merged
rjbou merged 3 commits intoocaml:masterfrom
rjbou:clean-tests
Sep 5, 2025
Merged

reftests: Clean some tests#6671
rjbou merged 3 commits intoocaml:masterfrom
rjbou:clean-tests

Conversation

@rjbou
Copy link
Copy Markdown
Collaborator

@rjbou rjbou commented Sep 4, 2025

No description provided.

@rjbou
Copy link
Copy Markdown
Collaborator Author

rjbou commented Sep 4, 2025

I'm wondering if I add some reftest scripts cleaning too, like the basedir defintion from sed to printf, here document instead of multiple echo with escaped ", etc.

@kit-ty-kate
Copy link
Copy Markdown
Member

I'm wondering if I add some reftest scripts cleaning too, like the basedir defintion from sed to printf, here document instead of multiple echo with escaped ", etc.

If you think it'll be easy enough to review, then sure. Otherwise maybe leaving it separate to be done later might be better to avoid some rebasing pain if it takes longer to review. As you wish

@rjbou rjbou marked this pull request as ready for review September 5, 2025 14:07
@rjbou rjbou requested a review from kit-ty-kate September 5, 2025 14:08
Copy link
Copy Markdown
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebase

@rjbou rjbou merged commit c36dd1c into ocaml:master Sep 5, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants