Handle non-displayable characters when detecting an erroneous package name or version#6640
Merged
rjbou merged 4 commits intoocaml:masterfrom Aug 25, 2025
Merged
Conversation
772dd45 to
3f7e683
Compare
rjbou
reviewed
Aug 22, 2025
| # Return code 2 # | ||
| ### opam show bépo | ||
| opam: PACKAGES… arguments: Invalid character '�' in package name | ||
| opam: PACKAGES… arguments: Invalid character '\195' in package name |
Collaborator
There was a problem hiding this comment.
Shouldn't these test be on their specific file ?
Member
Author
There was a problem hiding this comment.
with just error cases or something like that? Why not, although i don't feel a strong need for it personally
Member
Author
yeah sorry, i didn't clean up the PR at the time because it was queued on another PR so it needed rebasing anyway and i forgot to do it during the post-merge rebase. |
3f7e683 to
7f11077
Compare
…er in the package version
7f11077 to
491c0b7
Compare
rjbou
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #6638
Queued on #6638related to #6396