Invalid character in package name should explain why#6638
Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom Aug 13, 2025
Merged
Invalid character in package name should explain why#6638kit-ty-kate merged 2 commits intoocaml:masterfrom
kit-ty-kate merged 2 commits intoocaml:masterfrom
Conversation
… characters in package names
4a3727c to
ac4fd4f
Compare
kit-ty-kate
approved these changes
Aug 13, 2025
Member
kit-ty-kate
left a comment
There was a problem hiding this comment.
Thanks! I've added some tests to actually show up the feature and opened a follow up PR to handle non-displayable/UTF-8 characters better in #6640
ac4fd4f to
8dbe4e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.