source: add --no-checksums & --require-checksums flags to harmonise with opam install (fetch options)#5563
Conversation
src/client/opamCommands.ml
Outdated
| mk_flag ~cli (cli_from cli2_2) ["require-checksums"] | ||
| "Enforce checksum verification befor downloading sources.\ | ||
| This is equivalent to setting $(b,\\$OPAMREQUIRECHECKSUMS) to \"true\"." | ||
| in |
There was a problem hiding this comment.
might be worth sharing the flags definitions with the ones used in OpamArg.build_options ? (maybe that was too tedious to be worth it, in that case it's alright)
There was a problem hiding this comment.
|
Appreciated, and this looks great to me. As @AltGr mentioned, it may be useful to share some code. Thanks a lot. |
ef3b1e2 to
a5171aa
Compare
There was a problem hiding this comment.
I don't understand this feature request. What does this bring in terms of change for users?
I understand --require-checksums, although i feel like this would have more usability as a global opam option.
But --no-checksums i really don't understand. If the goal is to allow packages without a checksum, then why not simply add a --allow-no-checksums argument instead of ignoring the checksum altogether?
I'm also wondering what how opam source is special compared to the other commands that might fetch packages.
--no-checksums & --require-checksums flags--no-checksums & --require-checksums flags to harmonise with opam install (build options)
--no-checksums & --require-checksums flags to harmonise with opam install (build options)--no-checksums & --require-checksums flags to harmonise with opam install (fetch options)
/cc @hannesm @reynir