Reftests: add tests to check url handling behaviours#5560
Merged
rjbou merged 13 commits intoocaml:masterfrom Aug 29, 2023
Merged
Reftests: add tests to check url handling behaviours#5560rjbou merged 13 commits intoocaml:masterfrom
rjbou merged 13 commits intoocaml:masterfrom
Conversation
This was referenced May 26, 2023
Member
|
to me, this looks fine. thanks for your work on this. |
Member
|
Anything that can be done to get this merged? IMHO once this is merged, reviewing the related PRs is way easier. Again, thanks a lot for your work. :) |
Member
|
@hannesm this is waiting on my review. This wasn't queued for 2.2.0 until a few days ago and i haven't had the time to look at it. We're having a meeting in 25 minutes so I'll ask a few question directly there. Mainly this PR is confusing to me as it includes fixes (3706ac3, 9bcdac8) whereas the PR was specifically made just to add tests-cases. I have no idea why these fixes are there and what they are doing so this is the main reason i did not do it yesterday |
774af93 to
58abe26
Compare
kit-ty-kate
reviewed
Aug 22, 2023
kit-ty-kate
reviewed
Aug 29, 2023
tests/reftests/local-cache.test
Outdated
| echo "MD5: $md5" | ||
| echo "SHA256: $sha256" | ||
| echo "MD5: $(check "$MD5_PATH")" | ||
| echo "SHA256: $(check "$SHA256_PATH")" |
kit-ty-kate
approved these changes
Aug 29, 2023
Collaborator
Author
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three similar tests, one per each field: url, extra-sources & extra-files.
Each test check presence, checksum validation, and cache populating.
test introduced in #5538 is integrated in url test file.
/cc @hannesm @reynir
queued