Expand variable interpolations in build-env#5352
Merged
dra27 merged 4 commits intoocaml:masterfrom Jan 23, 2023
Merged
Conversation
Member
|
What would be the backward compatibility story with this change? Could we maybe detect that the package contains |
Member
Author
|
Hah, I was just preparing a long justification for why breaking backwards compatibility might be OK... but then I discovered that this is actually fixing a 1.2.2 -> 2.0 regression! |
rjbou
approved these changes
Nov 22, 2022
Collaborator
rjbou
left a comment
There was a problem hiding this comment.
LGTM, missing api changelog & test
5 tasks
Merged
kit-ty-kate
pushed a commit
to kit-ty-kate/opam
that referenced
this pull request
Feb 17, 2023
Expand variable interpolations in `build-env`
rjbou
pushed a commit
to kit-ty-kate/opam
that referenced
this pull request
May 12, 2023
Expand variable interpolations in `build-env`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variable interpolations (
%{lib}%, etc.) are expanded insetenvbut weren't expanded inbuild-env.I'd be willing to regard this as having been a bug, and don't expect that we'll find any instances of
build-envbeing used where%{foo}%was supposed to be treated as a literal string (with this PR, such strange usage should now be written%%{foo}%%).