Update external dependencies to dose 3.2-rc1 and ocamlgraph 1.8.5 by rdicosmo · Pull Request #1336 · ocaml/opam

rdicosmo · 2014-04-15T10:25:04Z

*** DO NOT MERGE THIS PR YET *** *** DO NOT MERGE THIS PR YET ***

Update external dependencies, moving to recent version of Dose+Cudf+Ocamlgraph, in preparation for the new release of Dose 3.2 and Cudf 0.7 that are impending.

Before merging, changes will need to be made to the Travis test environment, once the new version of the dose and cudf package will be on opam-repository.

To ensure a smooth transition, I want to collect feedback from the Travis output here, even if surely polluted by errors coming from unaligned versions of dose+cudf+ocamlgraph in the test environment.

rdicosmo · 2014-04-15T10:59:00Z

Build #569.1 is irrelevant, as opam is compiled with old opam/cudf/ocamlgraph up to now :-(

AltGr · 2014-04-16T09:31:56Z

I have just created a small repository corresponding to these packages with your patches, to help with testing. It's at https://github.com/OCamlPro/opam-repository-dose

It's the easiest way to get opam-rt to build & run with the right versions.

rdicosmo · 2014-04-16T09:38:33Z

Cool! Crossing my fingers waiting for your results : I'd love to see
all this pass all of opam-rt tests in one go, even if I know that
reality may be different :-)

On Wed, Apr 16, 2014 at 02:31:57AM -0700, Louis Gesbert wrote:

I have just created a small repository corresponding to these packages with
your patches, to help with testing. It's at https://github.com/OCamlPro/
opam-repository-dose

It's the easiest way to get opam-rt to build & run with the right versions.

—
Reply to this email directly or view it on GitHub.*

Roberto Di Cosmo

Professeur En delegation a l'INRIA
PPS E-mail: roberto@dicosmo.org
Universite Paris Diderot WWW : http://www.dicosmo.org
Case 7014 Tel : ++33-(0)1-57 27 92 20
5, Rue Thomas Mann
F-75205 Paris Cedex 13 Identica: http://identi.ca/rdicosmo

FRANCE. Twitter: http://twitter.com/rdicosmo

Attachments:
MIME accepted, Word deprecated

http://www.gnu.org/philosophy/no-word-attachments.html

Office location:

Bureau 3020 (3rd floor)
Batiment Sophie Germain
Avenue de France

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

GPG fingerprint 2931 20CE 3A5A 5390 98EC 8BFC FCCA C3BE 39CB 12D3

AltGr · 2014-04-16T09:40:19Z

... and with that I can confirm that all tests pass with the new versions. (I tested with NOASPCUD too)

rdicosmo · 2014-04-16T09:46:30Z

WOW :-) That's great, thanks!!!!

2014-04-16 11:40 GMT+02:00 Louis Gesbert notifications@github.com:

... and with that I can confirm that all tests pass with the new versions.
(I tested with NOASPCUD too)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1336#issuecomment-40580808
.

Roberto Di Cosmo

Professeur En delegation a l'INRIA
PPS E-mail: roberto@dicosmo.org
Universite Paris Diderot WWW : http://www.dicosmo.org
Case 7014 Tel : ++33-(0)1-57 27 92 20
5, Rue Thomas Mann
F-75205 Paris Cedex 13 Identica: http://identi.ca/rdicosmo

FRANCE. Twitter: http://twitter.com/rdicosmo

Attachments:
MIME accepted, Word deprecated

http://www.gnu.org/philosophy/no-word-attachments.html

Office location:

Bureau 320 (3rd floor)
Batiment Sophie Germain
Avenue de France

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

GPG fingerprint 2931 20CE 3A5A 5390 98EC 8BFC FCCA C3BE 39CB 12D3

rdicosmo · 2014-04-30T20:39:34Z

Updated for cudf-0.7

samoht · 2014-04-30T22:23:34Z

===== ERROR while installing dose.3.1.2 =====
# opam-version 1.1.1
# os           linux
# command      ocp-build -scan -init dose -v 0
# path         /home/travis/.opam/system/build/dose.3.1.2
# compiler     system (4.01.0)
# exit-code    2
# env-file     /home/travis/.opam/system/build/dose.3.1.2/dose-15944-629056.env
# stdout-file  /home/travis/.opam/system/build/dose.3.1.2/dose-15944-629056.out
# stderr-file  /home/travis/.opam/system/build/dose.3.1.2/dose-15944-629056.err
### stderr ###
# ...[truncated]
# Error:
# [54.1] '/usr/bin/ocamlc.opt' '-bin-annot' '-c' '-o' '_obuild/54/cudfSolver.cmo' '-for-pack' 'Common' '-I' './_obuild/dose/Common' '-I' './_obuild/dose' '-I' '.' '-I' '/home/travis/.opam/system/lib/cudf' '-I' '/home/travis/.opam/system/lib/extlib' '-I' '/home/travis/.opam/system/lib/ocamlgraph' '-I' '/home/travis/.opam/system/lib/ocaml' '-I' '/home/travis/.opam/system/lib/re' 'common/cudfSolver.ml'
# 
# File "common/cudfSolver.ml", line 101, characters 2-22:
# Error: Unbound module Cudf_printer
# 
# Error:
# Target _obuild/dose/Common/cudfSolver.cmi not built
# Error:
# Target _obuild/dose/Common/cudfSolver.cmo not built

rdicosmo · 2014-05-01T07:01:26Z

Hmm... the new Makefile requires that I adapt this PR... working on labour day, oh my! :-)

rdicosmo · 2014-05-01T07:25:09Z

No surprise here, this is a PR that requires moving to dose 3.2, and does
not work with dose 3.1 (that's why there is a big *** do not merge ***
disclaimer at the top).

We need cudf 0.7 (done) and dose 3.2 (in the works) in the repo, plus an update
to the travis scripts for this to go through.

On Wed, Apr 30, 2014 at 03:23:35PM -0700, Thomas Gazagnaire wrote:

===== ERROR while installing dose.3.1.2 =====

opam-version 1.1.1

os linux

command ocp-build -scan -init dose -v 0

path /home/travis/.opam/system/build/dose.3.1.2

compiler system (4.01.0)

exit-code 2

env-file /home/travis/.opam/system/build/dose.3.1.2/dose-15944-629056.env

stdout-file /home/travis/.opam/system/build/dose.3.1.2/dose-15944-629056.out

stderr-file /home/travis/.opam/system/build/dose.3.1.2/dose-15944-629056.err

stderr

...[truncated]

Error:

[54.1] '/usr/bin/ocamlc.opt' '-bin-annot' '-c' '-o' '_obuild/54/cudfSolver.cmo' '-for-pack' 'Common' '-I' './_obuild/dose/Common' '-I' './_obuild/dose' '-I' '.' '-I' '/home/travis/.opam/system/lib/cudf' '-I' '/home/travis/.opam/system/lib/extlib' '-I' '/home/travis/.opam/system/lib/ocamlgraph' '-I' '/home/travis/.opam/system/lib/ocaml' '-I' '/home/travis/.opam/system/lib/re' 'common/cudfSolver.ml'

File "common/cudfSolver.ml", line 101, characters 2-22:

Error: Unbound module Cudf_printer

Error:

Target _obuild/dose/Common/cudfSolver.cmi not built

Error:

Target _obuild/dose/Common/cudfSolver.cmo not built

—
Reply to this email directly or view it on GitHub.*

Roberto Di Cosmo

Professeur En delegation a l'INRIA
PPS E-mail: roberto@dicosmo.org
Universite Paris Diderot WWW : http://www.dicosmo.org
Case 7014 Tel : ++33-(0)1-57 27 92 20
5, Rue Thomas Mann
F-75205 Paris Cedex 13 Identica: http://identi.ca/rdicosmo

FRANCE. Twitter: http://twitter.com/rdicosmo

Attachments:
MIME accepted, Word deprecated

http://www.gnu.org/philosophy/no-word-attachments.html

Office location:

Bureau 3020 (3rd floor)
Batiment Sophie Germain
Avenue de France

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

GPG fingerprint 2931 20CE 3A5A 5390 98EC 8BFC FCCA C3BE 39CB 12D3

rdicosmo · 2014-05-01T07:52:01Z

Ok, everything goes through when using lib-ext. Of course, the first Travis build fails, as it still uses dose-3.1 instead of 3.2.
We are getting there!

rdicosmo · 2014-05-04T13:30:02Z

Ok... need to wait for dose 3.2-rc2 to get to the repo index befor this can work.

… 1.8.5

rdicosmo · 2014-05-05T19:48:47Z

Finally, with b4af77a everything goes through and we are ready for moving to cudf 0.7 + dose 3.2 ... \o/ This PR can be merged now!

AltGr · 2014-05-06T09:28:33Z

Great, thanks for taking care of this ! I'd remove altogether the two Added... and Revert "Added..." patches, but looks otherwise perfect.

rdicosmo · 2014-05-06T10:15:14Z

Sorry for the reverted patch... I had removed it, but popped
up again after the last rebase: if you can clean up and merge, I'd be very grateful :-)

On Tue, May 06, 2014 at 02:28:34AM -0700, Louis Gesbert wrote:

Great, thanks for taking care of this ! I'd remove altogether the two Added...
and Revert "Added..." patches, but looks otherwise perfect.

—
Reply to this email directly or view it on GitHub.*

Roberto Di Cosmo

Professeur En delegation a l'INRIA
PPS E-mail: roberto@dicosmo.org
Universite Paris Diderot WWW : http://www.dicosmo.org
Case 7014 Tel : ++33-(0)1-57 27 92 20
5, Rue Thomas Mann
F-75205 Paris Cedex 13 Identica: http://identi.ca/rdicosmo

FRANCE. Twitter: http://twitter.com/rdicosmo

Attachments:
MIME accepted, Word deprecated

http://www.gnu.org/philosophy/no-word-attachments.html

Office location:

Bureau 3020 (3rd floor)
Batiment Sophie Germain
Avenue de France

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

GPG fingerprint 2931 20CE 3A5A 5390 98EC 8BFC FCCA C3BE 39CB 12D3

rdicosmo · 2014-05-06T10:57:21Z

Just cleaned up... and pushed again. Let's see if Travis is happy

rdicosmo · 2014-05-06T11:38:47Z

Ok, commit history clean, and incorporated fix by @AltGr ... can be merged now.

Update external dependencies to dose 3.2-rc1 and ocamlgraph 1.8.5

AltGr · 2014-05-06T13:39:16Z

Thanks !

samoht mentioned this pull request May 1, 2014

Disable warn-error, as it makes developing on a trunk compiler hard #1367

Merged

rdicosmo added 4 commits May 5, 2014 21:30

Change refs to external sources: moved to Dose 3.2-rc1 and Ocamlgraph…

0c3c04b

… 1.8.5

Remove obsolete patches

501fb97

Hardcode FILE macros for dose 3.2

095d594

Hardcode IFDEF macros assuming false for dose 3.2

d39ca82

rdicosmo added 7 commits May 6, 2014 12:53

Update for cudf-0.7 and guard cudf patch execution

99137ce

Fix ocamlgraph dep in Makefile

785e008

Add printer to dose compiled modules

77b47de

Removed spurious dominator from dose compiled modules

7685b1a

Fix url for cudf 0.7

963e2f8

Fix dependency order in dose module list

817a991

Updated for dose 3.2 release candidate 2

e5fd0c0

Document OPAMUPGRADECRITERIA

663f4c2

AltGr added a commit that referenced this pull request May 6, 2014

Merge pull request #1336 from rdicosmo/dose-trunk

6cb0788

Update external dependencies to dose 3.2-rc1 and ocamlgraph 1.8.5

AltGr merged commit 6cb0788 into ocaml:master May 6, 2014

Conversation

rdicosmo commented Apr 15, 2014

Uh oh!

rdicosmo commented Apr 15, 2014

Uh oh!

AltGr commented Apr 16, 2014

Uh oh!

rdicosmo commented Apr 16, 2014

FRANCE. Twitter: http://twitter.com/rdicosmo

http://www.gnu.org/philosophy/no-word-attachments.html

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

Uh oh!

AltGr commented Apr 16, 2014

Uh oh!

rdicosmo commented Apr 16, 2014

FRANCE. Twitter: http://twitter.com/rdicosmo

http://www.gnu.org/philosophy/no-word-attachments.html

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

Uh oh!

rdicosmo commented Apr 30, 2014

Uh oh!

samoht commented Apr 30, 2014

Uh oh!

rdicosmo commented May 1, 2014

Uh oh!

rdicosmo commented May 1, 2014

opam-version 1.1.1

os linux

command ocp-build -scan -init dose -v 0

path /home/travis/.opam/system/build/dose.3.1.2

compiler system (4.01.0)

exit-code 2

env-file /home/travis/.opam/system/build/dose.3.1.2/dose-15944-629056.env

stdout-file /home/travis/.opam/system/build/dose.3.1.2/dose-15944-629056.out

stderr-file /home/travis/.opam/system/build/dose.3.1.2/dose-15944-629056.err

stderr

...[truncated]

Error:

File "common/cudfSolver.ml", line 101, characters 2-22:

Error: Unbound module Cudf_printer

Error:

Target _obuild/dose/Common/cudfSolver.cmi not built

Error:

Target _obuild/dose/Common/cudfSolver.cmo not built

FRANCE. Twitter: http://twitter.com/rdicosmo

http://www.gnu.org/philosophy/no-word-attachments.html

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

Uh oh!

rdicosmo commented May 1, 2014

Uh oh!

rdicosmo commented May 4, 2014

Uh oh!

rdicosmo commented May 5, 2014

Uh oh!

AltGr commented May 6, 2014

Uh oh!

rdicosmo commented May 6, 2014

FRANCE. Twitter: http://twitter.com/rdicosmo

http://www.gnu.org/philosophy/no-word-attachments.html

Metro Bibliotheque Francois Mitterrand, ligne 14/RER C

Uh oh!

rdicosmo commented May 6, 2014

Uh oh!

rdicosmo commented May 6, 2014

Uh oh!

AltGr commented May 6, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants