Adjust spacing between spec items#822
Merged
jonludlam merged 5 commits intoocaml:masterfrom Feb 7, 2022
Merged
Conversation
Julow
approved these changes
Feb 7, 2022
|
|
||
| div.spec, .def-doc { | ||
| margin-bottom: 20px; | ||
| margin-bottom: 10px; |
Collaborator
There was a problem hiding this comment.
The margin for .spec is useless. It is slightly bigger than the margin-top of the documentation, but this should be changed instead. It is lower than the margin for .odoc-spec so won't have any effect there either.
I've adjusted a bit: jonludlam#42
+ Use the default margin for paragraph + Remove unecessary margin rule + Define margin in em
The more custom margin has no effect in most cases but when it does, it results in inconsistent spacing, for example between two pre blocks.
Reduce a bit the margin between the include summary and the expansion to highlight that they are different. Otherwise they are too close, which feels slighly off.
Member
Author
|
Thanks @Julow ! In it goes. |
jonludlam
added a commit
to jonludlam/opam-repository
that referenced
this pull request
Feb 8, 2022
CHANGES: Additions - New subcommand to resolve references (@panglesd, @lubega-simon, ocaml/odoc#812) - Improved rendering of long signatures (@panglesd, ocaml/odoc#782) - Handle comments attached to open statement as floating comment, instead of dropping them (@panglesd, ocaml/odoc#797) - Empty includes (containing entirely shadowed entries) are now hidden (@panglesd, ocaml/odoc#798) Bugs fixed - Fix a missing Result constructor during compile. This will cause some functor arguments to have different filenames (@jonludlam, ocaml/odoc#795) - Better memory/disk space usage when handling module alias chains (@jonludlam, ocaml/odoc#799) - Resolving class-type paths (ie., `val x : #c`) (@jonludlam, ocaml/odoc#809) - Skip top-level attributes while extracting the top comment. Fix top-comment extraction with PPX preprocessing (@jorisgio, ocaml/odoc#819) - Better handling of @canonical tags (@jonludlam, ocaml/odoc#820) - css: improved layout (@jonludlam, @Julow, ocaml/odoc#822)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small style fix: Make sure that the content is more obviously associated with the correct signature item.
Before:
After:
