Conversation
Signed-off-by: Jon Ludlam <jon@recoil.org>
Compilation only; no support for the new features. Signed-off-by: Jon Ludlam <jon@recoil.org>
Signed-off-by: Jon Ludlam <jon@recoil.org>
There was a problem hiding this comment.
Tsig_typesubst and Tsig_modsubst remain to be done, but the worst that can happen will be unresolved references if someone uses them.
Whereas without this PR you simply can't load the .cmt, .cmti or .cmi files.
I'm in favor of merging now and improving support later.
|
Thanks @jonludlam and @trefis. I'll merge once the CI is done. Looks stuck for now :/ I'll add a 4.08 build to Travis right after merging (or push into this PR if the current CI build still hasn't started by then). |
|
The 4.08 travis build might be tricky until |
|
Looks like we also transitively depend on Ocamlbuild, which needs a release (ocaml/ocamlbuild#294). |
|
True - though there at least pinning master works. |
|
@jonludlam or @trefis, would you mind opening a follow-up issue about "proper" support for the new 4.08 features? |
|
I've opened up #350 to track the new features in 4.08 |
Further work needs to be done to support the new typesubst/modsubst constructors.
Fixes #304