again, first glance, looks like we can just ignore the module_presence field.

That seems correct.

And in the same PR, Path.Pdot(x,y,z) became Path.Pdot(x,y).

The part that disappeared is an int, indicating a position in the module block, which odoc doesn't care about. The two remaining fields are the only ones we were looking at anyway.

And ocaml/ocaml#2122 introduced Tsig_typesubst and Tsig_modsubst to Typedtree.signature_item_desc.

These ones are more interesting indeed and we'll want to support them.
There's some choice to be made regarding what to do with them

apply the substitution and make them disappear from the generated doc
do not apply the substitution, just print them as is in the generated doc
same as (2) and additionnaly update the code for <module type> with type/module ... := ... to replace the type/module declaration by the := one in the signature.

(2) seems like the easiest to do right now, and a decent choice overall.
As for how to handle them: I think you should be able to treat them as normal types / modules (w.r.t resolving and expansion) and just print them a bit differently (that is: with the :=).

Odoc fails to compile with OCaml 4.08 #304

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions