Support multiple inputs in markdown-generate (and html-generate)#1388
Merged
jonludlam merged 4 commits intoocaml:masterfrom Oct 16, 2025
Merged
Support multiple inputs in markdown-generate (and html-generate)#1388jonludlam merged 4 commits intoocaml:masterfrom
jonludlam merged 4 commits intoocaml:masterfrom
Conversation
This was referenced Oct 15, 2025
Member
|
This seems a totally reasonable change to me. Thanks, @davesnx ! |
rgrinberg
pushed a commit
to ocaml/dune
that referenced
this pull request
Feb 6, 2026
This PR extends odoc to support markdown-generate implemented here ocaml/odoc#1341 and supported since odoc.3.1.0 but it currently depends on another PR ocaml/odoc#1388 that isn't released (that's why I do the changes in nix [`7e386e6` (#12581)](7e386e6) and If I could get another pair of eyes if it's correct) The implementation itself tried to be very similar to the html generation, except the directory targets on a flat package. The PR adds: ```bash dune build @doc-markdown ``` Based on #12477 --------- Signed-off-by: David Sancho Moreno <dsnxmoreno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since integrating markdown in dune (ocaml/dune#12477), I found (idea by @jonludlam) would be helpful to generate markdown files from a list of odocl files.
This change is propagated into html-generate (which I belive is a nice addition and it doesn't break any previous usage of the cli). If you prefer to not change this, I could implement a new
Main.generate