revert commit 1d8e590 from OCaml (PR#6475)#51
Conversation
|
See also ocaml/ocaml#464. |
|
@whitequark, you are in charge :-) |
revert commit 1d8e590 from OCaml (PR#6475)
|
Sure. |
|
I think we should make a new release of ocamlbuild with this patch. Because currently we can't test the 4.03 branch easily (ex: cryptokit broken). @gasche I though you wrote somewhere the step for a release of ocamlbuild but I can't find where it is. |
|
@bobot thinking about this more, I'm not sure why we need to do a release quickly, though. Can't you just pin ocamlbuild to its master branch while doing your testing? The reason I ask instead of just releasing is that I expect this situation to happen again in the future: OCaml upstream will change its compilation behaviour in ways that require ocamlbuild changes. I'm not sure we should immediately do a release -- at least if there is an another way to use some "safe with trunk" branch without constantly making releases. In this specific case, we know this behavior will be as currently in the 4.03 release, and we don't expect other ocaml-side changes to break ocamlbuild, so it makes sense to have a release between now and 4.03 release anyway. So I'm fine with having a release. But I would like you (or someone else) to work out a process to use pinning instead, because in the general case we shouldn't have to release to keep in synch. |
|
When ocaml trunk is incompatible with the last ocambuild release pinning is
the solution. But here it is 4.03 branch not trunk. I think people are
expected to test it with as much project as possible (I already found a
typing regression, reported). Even if people are just expected to test the
beta that @doligez will soon publish; for the same reason that we needed a
working ocamlbuild opam package for 4.03, we need one for the beta.
|
|
But you were agreeing about what I just say.... I can make a merge request |
|
@whitequark , now that ocaml/ocaml#464 has been merged, do you have any advice on how to handle it on the ocamlbuild side? Given that people may use recent ocamlbuild version but keep using 4.03, we probably can't just revert the revert; I suspect that the easiest way is to leave the code as-is, maybe with a comment there that >=4.04 OCaml version would actually support the |
|
@gasche It is rather unfortunate, but I agree that there's probably no other way forward. |
This reverts the part of ocaml/ocaml@1d8e590 that was in ocamlbuild.
It's needed because the corresponding feature is (temporarily) removed from OCaml.