Fix -fdebug-prefix-map when using flexlink#9925
Merged
dra27 merged 2 commits intoocaml:trunkfrom Sep 21, 2020
Merged
Conversation
2b202d8 to
4d97a5a
Compare
Merged
Prepend the -fdebug-prefix-map= option with -link if the "linker" is in fact flexlink.
4d97a5a to
2bc77ee
Compare
Member
Author
|
Simpler implementation - rather than testing whether the linker command looks like flexlink, this instead determines whether it should be flexlink. |
Member
Author
|
Oops - sorry, I didn't update |
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Fix -fdebug-prefix-map when using flexlink (cherry picked from commit 507f40e)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Fix -fdebug-prefix-map when using flexlink (cherry picked from commit 507f40e)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Fix -fdebug-prefix-map when using flexlink (cherry picked from commit 507f40e)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Fix -fdebug-prefix-map when using flexlink (cherry picked from commit 507f40e)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Fix -fdebug-prefix-map when using flexlink (cherry picked from commit 507f40e)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Aug 4, 2024
Fix -fdebug-prefix-map when using flexlink (cherry picked from commit 507f40e)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Aug 4, 2024
Fix -fdebug-prefix-map when using flexlink (cherry picked from commit 507f40e)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Aug 4, 2024
Fix -fdebug-prefix-map when using flexlink (cherry picked from commit 507f40e)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Aug 4, 2024
Fix -fdebug-prefix-map when using flexlink (cherry picked from commit 507f40e)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jun 28, 2025
Fix -fdebug-prefix-map when using flexlink (cherry picked from commit 507f40e)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jun 28, 2025
Fix -fdebug-prefix-map when using flexlink (cherry picked from commit 507f40e)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jun 28, 2025
Fix -fdebug-prefix-map when using flexlink (cherry picked from commit 507f40e)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jun 28, 2025
Fix -fdebug-prefix-map when using flexlink (cherry picked from commit 507f40e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Cygwin, the
-fdebug-prefix-mapoption is available. However, this gets passed toflexlinkwhen configured with--enable-shared. This at present works with Cygwin's flexdll package because downstream patched flexlink. I'm not totally convinced that flexlink should blindly pass all-foptions on because of the MSVC implications, so I think this is better fixed correctly at the OCaml end.This PR introduces a check in
Ccompto determine ifConfig.mkexeis in factflexlink. If so, it prepends-linkto causeflexlinkto correctly pass the flag on.