Adapt caml_alloc_dummy_infix to new closure representation#9690
Merged
xavierleroy merged 1 commit intoocaml:trunkfrom Jun 17, 2020
Merged
Adapt caml_alloc_dummy_infix to new closure representation#9690xavierleroy merged 1 commit intoocaml:trunkfrom
xavierleroy merged 1 commit intoocaml:trunkfrom
Conversation
The first closure info field must be valid. Also document two other places where no change is needed because of the new closure representation, but for nonobvious reasons.
EduardoRFS
pushed a commit
to esy-ocaml/ocaml
that referenced
this pull request
May 17, 2021
sadiqj
pushed a commit
to sadiqj/ocaml
that referenced
this pull request
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noticed by @jhjourdan in #9619 (comment), the first closure info field must be valid.
Also document two other places where no change is needed because of the new closure representation, but for non-obvious reasons.