pattern-matching refactoring: keep going#9447
Merged
gasche merged 5 commits intoocaml:trunkfrom Apr 16, 2020
Merged
Conversation
Octachron
reviewed
Apr 15, 2020
Octachron
reviewed
Apr 15, 2020
9eb1e8f to
761383d
Compare
Octachron
approved these changes
Apr 16, 2020
Member
Octachron
left a comment
There was a problem hiding this comment.
The refactoring look good overall:
- Restricting the return type of
what_is_casesseems more natural - Moving the preprocessing logic out of the
split_and_precompilefunction seems to work - Reusing
compile_match_nonemptyincompile_matchis a clear win. - The new function is quite clearer.
Member
Author
|
Merged, thanks! I'll try to send the next PR of the stack soon, and also work on |
gasche
added a commit
to trefis/ocaml
that referenced
this pull request
May 2, 2020
gasche
added a commit
to trefis/ocaml
that referenced
this pull request
Jun 7, 2020
This comes from a suggestion by Florian Angeletti in ocaml#9447 (comment)
gasche
added a commit
to trefis/ocaml
that referenced
this pull request
Jun 8, 2020
This comes from a suggestion by Florian Angeletti in ocaml#9447 (comment)
gasche
added a commit
to trefis/ocaml
that referenced
this pull request
Jul 9, 2020
This comes from a suggestion by Florian Angeletti in ocaml#9447 (comment)
gasche
added a commit
to gasche/ocaml
that referenced
this pull request
Nov 18, 2020
This comes from a suggestion by Florian Angeletti in ocaml#9447 (comment)
gasche
added a commit
to trefis/ocaml
that referenced
this pull request
Nov 21, 2020
This comes from a suggestion by Florian Angeletti in ocaml#9447 (comment)
anmonteiro
pushed a commit
to melange-re/melange-compiler-libs
that referenced
this pull request
Mar 7, 2022
This comes from a suggestion by Florian Angeletti in ocaml/ocaml#9447 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the next bit of the big pattern-matching refactoring change (#9321) after #9417 has been merged. This one is a series of small commits that iterate simple refactorings; they should be reviewed independently.
(Internal: there was a bit of rebase work due to the (nice!) change of arguments of the
split_and_precompile_*function fromargsto~argsuggested by @Octachron during the review of #9322.)