Correct implementation of --disable-stdlib-manpages#9335
Merged
dra27 merged 1 commit intoocaml:trunkfrom Apr 17, 2020
Merged
Conversation
Member
Author
|
Note the difference between Travis Job 16730.2 for this PR and the recent 16723.2 for trunk. |
Member
|
Ahem, apologies for dropping the ball on this one. I didn't do a full review, but it looks correct to me and I think you could merge. (I was nervous about the assumption that |
Contributor
|
The code looks okay to me, many thanks for having given me the opportunity
to review.
The Changes entry needs to be completed before merging, though.
|
db1104f to
9c5d7c1
Compare
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Correct implementation of --disable-stdlib-manpages (cherry picked from commit 43c84d2)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Correct implementation of --disable-stdlib-manpages (cherry picked from commit 43c84d2)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Correct implementation of --disable-stdlib-manpages (cherry picked from commit 43c84d2)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Correct implementation of --disable-stdlib-manpages (cherry picked from commit 43c84d2)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Correct implementation of --disable-stdlib-manpages (cherry picked from commit 43c84d2)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Correct implementation of --disable-stdlib-manpages (cherry picked from commit 43c84d2)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Aug 4, 2024
Correct implementation of --disable-stdlib-manpages (cherry picked from commit 43c84d2)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Aug 4, 2024
Correct implementation of --disable-stdlib-manpages (cherry picked from commit 43c84d2)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Aug 4, 2024
Correct implementation of --disable-stdlib-manpages (cherry picked from commit 43c84d2)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Aug 4, 2024
Correct implementation of --disable-stdlib-manpages (cherry picked from commit 43c84d2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of #8835 was accidentally broken by #8837. I think this PR amends #8835 to work in the spirit of the change made in #8837 (which was to make the building of manpages explicit). It means that
make -C ocamldoc allnow never builds the manpages, which I think is OK? As things presently stand, I think the manpages target would have been being called twice.cc @gasche