Fix the way the ocamldoc bytecode executable is called under Windows.#906
Merged
alainfrisch merged 1 commit intoocaml:trunkfrom Nov 10, 2016
Merged
Conversation
be6b634 to
a2616bc
Compare
This fixes a problem related to the way ocamldoc's bytecode executable is called under Windows, reported by @alainfrisch at ocaml#808 (comment) As he explains, ``Even if the PATH is extended with explicit paths to otherlibs/win32unix and otherlibs/str, ocamlrun will still look up the stub dlls in the installation directory first, as can be seen by setting OCAMLRUNPARAM=v=256. If another version was installed in the same target directory before, the old dlls will be loaded which can lead to failure (e.g. I just got "Fatal error: unknown C primitive 'unix_lstat'"). A fix could be to set: CAML_LD_LIBRARY_PATH="../otherlibs/win32unix;../otherlibs/str" instead of changing PATH''. This commit implements the proposed fix, due to @alainfrisch.
a2616bc to
ed16260
Compare
Contributor
|
Thanks for the confirmation. Since this is a complement to a recent (unreleased) PR, I guess we can go without a Changelog entry. |
camlspotter
pushed a commit
to camlspotter/ocaml
that referenced
this pull request
Oct 17, 2017
…ocaml#906) This fixes a problem related to the way ocamldoc's bytecode executable is called under Windows, reported by @alainfrisch at ocaml#808 (comment) As he explains, ``Even if the PATH is extended with explicit paths to otherlibs/win32unix and otherlibs/str, ocamlrun will still look up the stub dlls in the installation directory first, as can be seen by setting OCAMLRUNPARAM=v=256. If another version was installed in the same target directory before, the old dlls will be loaded which can lead to failure (e.g. I just got "Fatal error: unknown C primitive 'unix_lstat'"). A fix could be to set: CAML_LD_LIBRARY_PATH="../otherlibs/win32unix;../otherlibs/str" instead of changing PATH''. This commit implements the proposed fix, due to @alainfrisch.
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Oct 25, 2022
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
…aml#906) * consider reverse dependencies when ranking package search results * Leaner interface Co-authored-by: Sabine Schmaltz <sabine@tarides.com> Co-authored-by: Cuihtlauac ALVARADO <cuihtmlauac@tarides.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #808. More specifically, it fixes the problem
reported by @alainfrisch at
#808 (comment)
Many thanks to him for having both reported the issue and suggested a fix.