build system: remove the config/ directory#8720
Merged
dra27 merged 1 commit intoocaml:trunkfrom Jun 10, 2019
Merged
Conversation
dra27
reviewed
Jun 10, 2019
Member
dra27
left a comment
There was a problem hiding this comment.
Some typos. I'd suggest completely reverting the changes to configure.ac (and so configure). It's better to keep the full path as git log -- config/m-nt.h will still work after this PR is merged. At some point in the future, the entire comment will be superfluous and can be deleted.
None of the files in this directory is used any more.
49af850 to
acff233
Compare
Contributor
Author
|
Thanks a lot, @dra27.
The branch has been rebased and I believe that I have taken into account
all your comments.
|
Member
|
Indeed, thanks @shindere! |
Member
|
Cherry-picked to 4.09: 405cff3 |
Contributor
Author
Contributor
Author
|
David Allsopp (2019/06/10 06:00 -0700):
Cherry-picked to 4.09: 405cff3
Thanks for that, too. I wasn't sure but happy you made the decision. :)
|
Member
It made sense that they were left around for 4.08, but there's certainly already been one instance of someone not realising that they're not supposed to be being used anymore, so better to eliminate the confusion! |
Contributor
Author
|
David Allsopp (2019/06/10 06:10 -0700):
@shindere:
> David Allsopp (2019/06/10 06:00 -0700):
> Cherry-picked to 4.09: 405cff3
>
> Thanks for that, too. I wasn't sure but happy you made the decision. :)
It made sense that they were left around for 4.08, but there's
certainly already been one instance of someone not realising that
they're not supposed to be being used anymore, so better to eliminate
the confusion!
+1!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of the files in this directory is used any more.