Generate ocaml_compiler_internal_params from ./configure arguments#865
Generate ocaml_compiler_internal_params from ./configure arguments#865stedolan wants to merge 1 commit intoocaml:trunkfrom
Conversation
|
I think this would fit in well with what I was envisaging for multilib support (where all the options would be available at runtime, at least for configured variants of the system, but defaults would still be settable via The one thing I think we should be careful of is to ensure that the names are obviously consistent with "something else" (e.g. the names of compiler flags). |
|
First of all, the PR will probably need to be rebased to take into
account the merge of build systems in stdlib.
Beyond that, I am unclear about where this file is supposed to come from
when it is not generated from configure. The Changes file says its
existence has been documented but I can't find where.
Finally, rather than specifying the parameters themselves, wouldn't it
be simpler to specify the path to a file that should be copied to stdlib
and then used?
Sorry if the question is dumb, I'm probably lacking some background
here.
|
By default, this file does not exist.
Some documentation was added in #879, now living in the manual (
Since many interesting uses of this file specify only one or two options, it's quite handy to be able to write them directly in the |
|
Is anyone interested in this? (I'm happy to rebase it to trunk, if there's some demand for this feature. Otherwise I'll just close the PR) |
|
I realise I didn't respond, sorry about that.
Actually, I'd prefere somebody else to give an opinion.
|
|
I agree that getting rid of those horrible lines in .comp (or for OPAM 2.0, in the ocaml package) is a good objective, but I'm not convinced that un-validated parameters to configure is the way to do it (isn't ocaml_compiler_internal_params kind of a hack in the first place?) Might it be cleaner (from the point of view of being able to remove it in the future) if:
I'm thinking along the lines of tools/msvs-promote-path which is an external helper script for using MSVC inside Cygwin, rather than a structured part of either the compiler or the build system. |
004657a to
8241489
Compare
|
@dra27 That is a better idea. I've changed it to work like that. |
| install:: | ||
| cp stdlib.cma std_exit.cmo *.cmi *.cmt *.cmti *.mli *.ml \ | ||
| camlheader_ur \ | ||
| camlheader_ur ocaml_compiler_internal_params \ |
There was a problem hiding this comment.
Isn't the case that this file only gets created if you run the set-default-params script? In which case, won't this error if you don't run it? $(wildcard ocaml_compiler_internal_params) should fix it, I think.
|
@damiendoligez : do you really want a 4.06 milestone on this GPR? It doesn't feel ready to me. |
|
Right. This doesn't look urgent, and this time we are aiming for a very fast release cycle. |
|
The initial reasons for wanting this have gone away (OPAM no longer uses the hack to enable |
* Frontend: Icon sharing, preparation * Add id to svg elements * Sort icons alphabetically * Move icon aliases into Icons class * Identify some SVG paths * Replace inlined svg by icon definitions * Uniform api * Inline more icons * Inline more icons, cont'd * more factoring out of icons, only a few left * icons are decorative, so should not be cause noise for screen readers * sidebar icon, homepage icons * Sort attributes * Fix badly copied class attributes * Fix tutorial icons --------- Co-authored-by: Cuihtlauac ALVARADO <cuihtmlauac@tarides.com> Co-authored-by: Sabine Schmaltz <sabine@tarides.com>
Allows setting default options by passing arguments to
./configure, without modifying./configurefor every option. Default options are entered intoocaml_compiler_internal_params. Example: