Merged
Conversation
There is a typo in the generated CSS for link to modules in the index page. CSS colors should start with `#`. As a consequence, this also makes the default stylesheet valid according to <https://jigsaw.w3.org/css-validator>.
Member
|
This raises the question of whether the resulting color is actually the one we want (maybe the rest of the design was changed by testing against the default color). But let's go for it for now, valid CSS is good. |
camlspotter
pushed a commit
to camlspotter/ocaml
that referenced
this pull request
Oct 17, 2017
Ocamldoc: fix CSS color declaration
ctk21
pushed a commit
to ocaml-multicore/ocaml
that referenced
this pull request
Jan 7, 2022
Move bytecode only startup code into startup_byt.c
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a typo in the generated CSS for link to modules in the index page. CSS colors should start with
#.As a consequence, this also makes the default stylesheet valid according to https://jigsaw.w3.org/css-validator.
Of course this changes the look of module lists so here's a preview:
Before this change
After this change
Thanks!