Closed
Conversation
xavierleroy
reviewed
Dec 4, 2016
| direct : Shortcut application function. Missing at N-1 level, or | ||
| for unoptimized arity levels. | ||
| val[0] : The argument stored in this closure. | ||
| val[1] : Pointer to the previous closure. |
Contributor
There was a problem hiding this comment.
The comments on val[0] and val[1] make no sense. In general we have N values that are the free variables of the closure or set of mutually recursive closures.
Contributor
|
I agree that more high-level comments would help there. But I don't think that your comments are particularly helpful, and the one I pointed out is just misleading. I move to close this PR. |
Contributor
|
Let's close it then. |
EduardoRFS
pushed a commit
to esy-ocaml/ocaml
that referenced
this pull request
Dec 17, 2021
Really flush output when pre-defined formatters are used in parallel.
quartz55
pushed a commit
to quartz55/ocaml
that referenced
this pull request
Feb 1, 2022
Really flush output when pre-defined formatters are used in parallel.
quartz55
pushed a commit
to quartz55/ocaml
that referenced
this pull request
Feb 1, 2022
Cherry pick: Merge pull request ocaml#701 from ocaml-multicore/really_flush
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Sep 21, 2022
Avoid unneeded work in lambda_to_flambda in normal mode
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
* Ood code uniformization: packages * Let metadata be the @@deriving yaml type * Let Packages.t be an alias of Packages.metadata * Misc required changes * Formatting Co-authored-by: Cuihtlauac ALVARADO <cuihtmlauac@tarides.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.