Conversation
|
This feels like code pattern-matching on the arguments of a constructor declaration, assuming that they are parsed in tuple-like form, and failing on new code using inline records. I am frustrated by the fact that I have no idea if the code you used to replace the |
This commit adds a very basic handling of inline record within
exceptions for signature items. Previously, a signature like
sig
exception E of {lbl:int}
end
would crash OCamldoc due to an assertion failure.
With this commit, the previous signature should be correctly
displayed by ocamldoc as
sig
exception E of {lbl:int}
end
Beware, that the same exception as structure item would still
crash ocamldoc at the time of this commit.
Beware: hese tests are incomplete, due to the incomplete handling of inline record within exception inside Ocamldoc.
502867e to
0f2ee32
Compare
This commit adds a new tests focused on the handling of inline records
by the latex generator. For now, it checks that the inline records
labels and types are at least printed within the latex file and not
replaced by `{...}`.
|
With further investigations, I discovered that the manual compilation was failing on the documentation for https://github.com/ocaml/ocaml/blob/trunk/utils/misc.mli#L312, due to the incomplete handling of I have added two incomplete tests for these inline records in Note that this pull request is only a partial fix, and there is still some assertion failure waiting to happen for inline records within ocamldoc, see for instance the commented example in |
|
Excellent, thanks! I created a MPR for it: MPR#7290. |
Manual: build fix
This PR makes the manual build again:
"insidecmds/intf-c.etexno idea why this assertion failure was triggered in the first place.