Add filename to system frametable for amd64#663
Merged
mshinwell merged 1 commit intoocaml:trunkfrom Jul 17, 2016
Merged
Conversation
Member
|
Looks safe enough. |
lpw25
pushed a commit
to janestreet/ocaml
that referenced
this pull request
Aug 10, 2016
camlspotter
pushed a commit
to camlspotter/ocaml
that referenced
this pull request
Oct 17, 2017
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch enables the system frametable on amd64 to be used for resolving the location of
caml_start_program. This is needed for Spacetime. I have not yet replicated this across all backends since we currently only support amd64 for instrumentation.This will make it clear in the main Spacetime patch that the changes to amd64.S are a no-op when Spacetime is not enabled.