cmpbyt: return 1 rather than 2 to report file difference.#624
Merged
damiendoligez merged 1 commit intoocaml:trunkfrom Jun 23, 2016
Merged
cmpbyt: return 1 rather than 2 to report file difference.#624damiendoligez merged 1 commit intoocaml:trunkfrom
damiendoligez merged 1 commit intoocaml:trunkfrom
Conversation
cmpbyt was returning 2 to report both an error in the way it is called (wrong number of command-line arguments) and the fact that its two arguments are different programs. This patch fixes this and makes cmpbyt's behaviour similar to the one of the cmp Unix command, i.e. returning 0 to report file similarity, 1 to report file difference and 2 for real errors.
camlspotter
pushed a commit
to camlspotter/ocaml
that referenced
this pull request
Oct 17, 2017
cmpbyt: return 1 rather than 2 to report file difference.
Merged
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
May 24, 2022
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
May 24, 2022
fe8a98b flambda-backend: Save Mach as Cfg after Selection (ocaml#624) 2b205d8 flambda-backend: Clean up algorithms (ocaml#611) 524f0b4 flambda-backend: Initial refactoring of To_cmm (ocaml#619) 0bf75de flambda-backend: Refactor and correct the "is pure" and "can raise" (port upstream PR#10354 and PR#10387) (ocaml#555) d234bfd flambda-backend: Cpp mangling is now a configuration option (ocaml#614) 20fc614 flambda-backend: Check that stack frames are not too large (ocaml#10085) (ocaml#561) 5fc2e95 flambda-backend: Allow CSE of immutable loads across stores (port upstream PR#9562) (ocaml#562) 2a650de flambda-backend: Backport commit fc95347 from trunk (ocaml#584) 31651b8 flambda-backend: Improved ARM64 code generation (port upstream PR#9937) (ocaml#556) f0b6d68 flambda-backend: Simplify processing and remove dead code (error paths) in asmlink (port upstream PR#9943) (ocaml#557) 90c6746 flambda-backend: Improve code-generation for inlined comparisons (port upstream PR#10228) (ocaml#563) git-subtree-dir: ocaml git-subtree-split: fe8a98b
lpw25
pushed a commit
to lpw25/ocaml
that referenced
this pull request
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmpbyt was returning 2 to report both an error in the way it is
called (wrong number of command-line arguments) and the fact that
its two arguments are different programs. This patch fixes this and makes
cmpbyt's behaviour similar to the one of the cmp Unix command, i.e.
returning 0 to report file similarity, 1 to report file difference
and 2 for real errors.