PR#7209: do not run at_exit handlers on exec failure#532
Merged
damiendoligez merged 1 commit into4.03from Apr 4, 2016
unknown repository
Merged
PR#7209: do not run at_exit handlers on exec failure#532damiendoligez merged 1 commit into4.03from unknown repository
damiendoligez merged 1 commit into4.03from
unknown repository
Conversation
Member
|
It looks to me that |
Author
|
Because of the call to |
Member
|
Ah ok. What we would like to do is clear the |
EduardoRFS
pushed a commit
to esy-ocaml/ocaml
that referenced
this pull request
May 17, 2021
…er_test Addition of test for finaliser callback with major cycle
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for PR#7209: use
sys_exitinstead ofexitin the child process whenexecv*fails.The various functions were inconsistent in the way they handled exceptions raised by code between the
fork () = 0and theexeccall. Some such ascreate_processhandled them the same asexecexceptions and exited with 127. Other such asopen_procdid not handle them, and I suppose let them leak to the caller which doesn't seem right. I changed the latter ones to behave the same as the former ones: i.e. any exception in the child process leads tosys_exit 127.It was less clear what to do for
establish_serverso I didn't change it