Merged
Conversation
Contributor
|
I am in favour. |
Contributor
|
I support this clean-up. |
Merged
Member
|
I don't agree that |
Contributor
|
I don't agree that `;;` is bad style, especially for beginners, but it's important to have the doc comments attached to the right thing.
I agree with you: the problem is not ';;' but having a simple and unambiguous
way to attach documentation to the right thing.
…-- Pierre Weis
INRIA Paris, http://bat8.inria.fr/~weis/
|
mshinwell
added a commit
to mshinwell/ocaml
that referenced
this pull request
Jul 1, 2021
EduardoRFS
pushed a commit
to esy-ocaml/ocaml
that referenced
this pull request
Jul 23, 2021
Expand CI runs
stedolan
added a commit
to stedolan/ocaml
that referenced
this pull request
May 24, 2022
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
* Delete example using marginBottom attribute * Remove marginBottom from Testimonials * Remove marginBottom from CallToAction.General * Remove marginBottom from CallToAction.TransparentWide * Remove marginBottom from HighlightsInQuadrants * Remove marginBottom from MediaCarousel * Remove marginBottom from MediaObject * Remove marginBottom from UserLevelIntroduction * Remove marginBottom from SectionContainer.MediumCentered * Remove marginBottom from SectionContainer.VerySmallCentered * Remove marginBottom from SectionContainer.ResponsiveCentered * Remove marginBottom from SectionContainer.NoneFilled * Remove marginBottom and marginTop from Page.Basic * Fix warning about unused variable * Remove marginBottom from Page.HighlightSection * Remove Tailwind module * Delete obsolete comment * Restore configurable sectionMargin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard library contains a few
;;lying around. I think these are generally considered bad style these days. Since the library is often used as an example of how OCaml code should look, it is probably a good idea to remove them.I've made this PR against 4.03 because some of the
;;are causing documentation comments not to be attached to definitions. As merlin is now providing documentation for values based on these attached comments it is important to fix them. I'll follow this up with another PR to enable warning 50 on the stdlib and fix up the ambiguous comments.