Provide more debugging information to Js_of_ocaml#455
Merged
damiendoligez merged 3 commits intoocaml:trunkfrom Feb 10, 2016
Merged
Provide more debugging information to Js_of_ocaml#455damiendoligez merged 3 commits intoocaml:trunkfrom
damiendoligez merged 3 commits intoocaml:trunkfrom
Conversation
Contributor
|
These psuedo events are useful for other things as well. I used a very similar (possibly identical) construct to improve backtraces in my work on array datatypes: I think it would also help to improve backtraces with flambda for some primitives. |
This debugging event provides information regarding the structure items. It is ignored by the OCaml debugger but is used by Js_of_ocaml to preserve variable names for debugging purpose.
damiendoligez
added a commit
that referenced
this pull request
Feb 10, 2016
Provide more debugging information to Js_of_ocaml
lukemaurer
added a commit
to lukemaurer/ocaml
that referenced
this pull request
May 17, 2021
…#455) The extra declaration was probably an error in merging or rebasing at some point.
EduardoRFS
pushed a commit
to esy-ocaml/ocaml
that referenced
this pull request
May 17, 2021
…fork No blocking section on fork
EduardoRFS
pushed a commit
to esy-ocaml/ocaml
that referenced
this pull request
May 17, 2021
This commit introduce an atfork hook in the runtime, as a follow up to the issue encountered in MPR ocaml#455 and MPR ocaml#471. To handle all the specific fork scenarios allowed in Multicore, a hook is required in order to let specific "alterations" to the runtime do their job: by default, on a single domain program, only the domain lock needs to be reset. When systhreads are in use, more cleaning up duty is required. As a result, the usage of pthreads_atfork is also removed, opting to rely in both case on manually calling the runtime hook when required.
sadiqj
pushed a commit
to sadiqj/ocaml
that referenced
this pull request
Jan 10, 2022
This commit introduce an atfork hook in the runtime, as a follow up to the issue encountered in MPR ocaml#455 and MPR ocaml#471. To handle all the specific fork scenarios allowed in Multicore, a hook is required in order to let specific "alterations" to the runtime do their job: by default, on a single domain program, only the domain lock needs to be reset. When systhreads are in use, more cleaning up duty is required. As a result, the usage of pthreads_atfork is also removed, opting to rely in both case on manually calling the runtime hook when required.
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Sep 21, 2022
* Added documentation about the inliner * Code review
xavierleroy
pushed a commit
to xavierleroy/ocaml
that referenced
this pull request
Oct 10, 2023
This commit introduce an atfork hook in the runtime, as a follow up to the issue encountered in MPR ocaml#455 and MPR ocaml#471. As a result, the usage of pthreads_atfork is also removed, opting to rely in both case on manually calling the runtime hook when required. This way, fork() calls from C code no longer reset the OCaml thread machinery. This should help with issues such as ocaml#12636. (cherry picked from commit c6d00ee) (and adapted to 4.14) Co-authored-by: xavier.leroy@college-de-france.fr
xavierleroy
pushed a commit
to xavierleroy/ocaml
that referenced
this pull request
Oct 26, 2023
This commit introduce an atfork hook in the runtime, as a follow up to the issue encountered in MPR ocaml#455 and MPR ocaml#471. As a result, the usage of pthreads_atfork is also removed, opting to rely in both case on manually calling the runtime hook when required. This way, fork() calls from C code no longer reset the OCaml thread machinery. This should help with issues such as ocaml#12636. (cherry picked from commit c6d00ee) (and adapted to 4.14) Co-authored-by: xavier.leroy@college-de-france.fr
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
* Some design of Acad page implemented * Some changes
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
Co-authored-by: tmattio <tmattio@users.noreply.github.com>
ejgallego
pushed a commit
to ejgallego/ocaml
that referenced
this pull request
Nov 5, 2025
This commit introduce an atfork hook in the runtime, as a follow up to the issue encountered in MPR ocaml#455 and MPR ocaml#471. As a result, the usage of pthreads_atfork is also removed, opting to rely in both case on manually calling the runtime hook when required. This way, fork() calls from C code no longer reset the OCaml thread machinery. This should help with issues such as ocaml#12636. (cherry picked from commit c6d00ee) (and adapted to 4.14) Co-authored-by: xavier.leroy@college-de-france.fr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Js_of_ocaml uses the environment associated to debugging events to get the original variable names, which is helpful for debugging.
As there is no event at toplevel in structures, we often don't have the name of module components.
This pull request adds a pseudo event (ignored by the OCaml debugger) at the very end of each structure to provide this information.