Skip to content

Define _ALL_SOURCE for AIX 7.1#383

Merged
mshinwell merged 2 commits intoocaml:trunkfrom
tkob:aix-all-source
Jan 5, 2016
Merged

Define _ALL_SOURCE for AIX 7.1#383
mshinwell merged 2 commits intoocaml:trunkfrom
tkob:aix-all-source

Conversation

@tkob
Copy link
Copy Markdown
Contributor

@tkob tkob commented Dec 31, 2015

This PR modifies configure scripts so that -D_ALL_SOURCE is added for AIX.

This is needed because some required constants and prototypes are defined
inside #ifdef _ALL_SOURCE

Examples are:

  • AI_NUMERICHOST constant in netdb.h (used from getaddrinfo.c)
  • chroot prototype in unistd.h (used from chroot.c)

This is needed because some required constants and prototypes are defined
inside `#ifdef _ALL_SOURCE`

Examples are:

- AI_NUMERICHOST constant in netdb.h (used from getaddrinfo.c)
- chroot prototype in unistd.h (used from chroot.c)
@mshinwell
Copy link
Copy Markdown
Contributor

Please add a Changes entry to your diff, thanks.

@gasche
Copy link
Copy Markdown
Member

gasche commented Jan 4, 2016

A detail point on the Changelog: the more common policy is to refer to contributors by their full names. If you prefer to be credited by your pseudonym, your current Changelog entry is fine, but you should also feel free to indicate another name -- this should go without saying, but it need not use the ASCII alphabet only, other UTF8 characters are fine.

@tkob
Copy link
Copy Markdown
Contributor Author

tkob commented Jan 5, 2016

I prefer to use this. Thank you for the comment.

mshinwell added a commit that referenced this pull request Jan 5, 2016
GPR#383: Define _ALL_SOURCE for AIX 7.1
@mshinwell mshinwell merged commit d1c05bc into ocaml:trunk Jan 5, 2016
@tkob tkob deleted the aix-all-source branch January 5, 2016 14:47
lukemaurer added a commit to lukemaurer/ocaml that referenced this pull request Apr 23, 2021
This reverts the parts of commit
9816841 that have been split off into
PRs ocaml#383 and ocaml#386, as well as the Bottom stuff (likely to be unnecessary
as we're considering making `Coercion.compose` a total function).
poechsel pushed a commit to poechsel/ocaml that referenced this pull request Apr 29, 2021
Print aliases for debug.

Various improvements

* Use `Coercion.t` rather than `Coercion.t option` in many places
* Use `Rec_info.t` again where sensible (in making inlining decisions,
  for instance), but redefine it as `unit` pending the next phase of
  `Rec_info` overhaul
* Add simple `int` fields to `Coercion.t` for changing recursion depth;
  this is simpler than what we'll actually need but specific enough that
  we can test meaningfully (e.g., we can tell whether coercions are
  composed in the right order)

Address a CR

Update .depend

Overhaul Aliases_of_canonical_element; add Alias_set

Also return Bottom from more places (generally anything involved in a
meet).

Use Rec_info.unknown instead of unit

Add comments; simplify `Aliases` API a bit

Revert (most of) "Overhaul Aliases_of_canonical_element; add Alias_set"

This reverts the parts of commit
9816841 that have been split off into
PRs ocaml#383 and ocaml#386, as well as the Bottom stuff (likely to be unnecessary
as we're considering making `Coercion.compose` a total function).
poechsel pushed a commit to poechsel/ocaml that referenced this pull request Apr 29, 2021
Print aliases for debug.

Various improvements

* Use `Coercion.t` rather than `Coercion.t option` in many places
* Use `Rec_info.t` again where sensible (in making inlining decisions,
  for instance), but redefine it as `unit` pending the next phase of
  `Rec_info` overhaul
* Add simple `int` fields to `Coercion.t` for changing recursion depth;
  this is simpler than what we'll actually need but specific enough that
  we can test meaningfully (e.g., we can tell whether coercions are
  composed in the right order)

Address a CR

Update .depend

Overhaul Aliases_of_canonical_element; add Alias_set

Also return Bottom from more places (generally anything involved in a
meet).

Use Rec_info.unknown instead of unit

Add comments; simplify `Aliases` API a bit

Revert (most of) "Overhaul Aliases_of_canonical_element; add Alias_set"

This reverts the parts of commit
9816841 that have been split off into
PRs ocaml#383 and ocaml#386, as well as the Bottom stuff (likely to be unnecessary
as we're considering making `Coercion.compose` a total function).
poechsel pushed a commit to poechsel/ocaml that referenced this pull request May 4, 2021
Print aliases for debug.

Various improvements

* Use `Coercion.t` rather than `Coercion.t option` in many places
* Use `Rec_info.t` again where sensible (in making inlining decisions,
  for instance), but redefine it as `unit` pending the next phase of
  `Rec_info` overhaul
* Add simple `int` fields to `Coercion.t` for changing recursion depth;
  this is simpler than what we'll actually need but specific enough that
  we can test meaningfully (e.g., we can tell whether coercions are
  composed in the right order)

Address a CR

Update .depend

Overhaul Aliases_of_canonical_element; add Alias_set

Also return Bottom from more places (generally anything involved in a
meet).

Use Rec_info.unknown instead of unit

Add comments; simplify `Aliases` API a bit

Revert (most of) "Overhaul Aliases_of_canonical_element; add Alias_set"

This reverts the parts of commit
9816841 that have been split off into
PRs ocaml#383 and ocaml#386, as well as the Bottom stuff (likely to be unnecessary
as we're considering making `Coercion.compose` a total function).
chambart pushed a commit to chambart/ocaml-1 that referenced this pull request Jan 4, 2022
EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
* title case fix in up & running

* fix top level to toplevel for consistency & to match style guide

Signed-off-by: Christine Rose <professor.rose@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants