Merged
Conversation
This is needed because some required constants and prototypes are defined inside `#ifdef _ALL_SOURCE` Examples are: - AI_NUMERICHOST constant in netdb.h (used from getaddrinfo.c) - chroot prototype in unistd.h (used from chroot.c)
Contributor
|
Please add a Changes entry to your diff, thanks. |
Member
|
A detail point on the Changelog: the more common policy is to refer to contributors by their full names. If you prefer to be credited by your pseudonym, your current Changelog entry is fine, but you should also feel free to indicate another name -- this should go without saying, but it need not use the ASCII alphabet only, other UTF8 characters are fine. |
Contributor
Author
|
I prefer to use this. Thank you for the comment. |
mshinwell
added a commit
that referenced
this pull request
Jan 5, 2016
GPR#383: Define _ALL_SOURCE for AIX 7.1
poechsel
pushed a commit
to poechsel/ocaml
that referenced
this pull request
Apr 29, 2021
Print aliases for debug. Various improvements * Use `Coercion.t` rather than `Coercion.t option` in many places * Use `Rec_info.t` again where sensible (in making inlining decisions, for instance), but redefine it as `unit` pending the next phase of `Rec_info` overhaul * Add simple `int` fields to `Coercion.t` for changing recursion depth; this is simpler than what we'll actually need but specific enough that we can test meaningfully (e.g., we can tell whether coercions are composed in the right order) Address a CR Update .depend Overhaul Aliases_of_canonical_element; add Alias_set Also return Bottom from more places (generally anything involved in a meet). Use Rec_info.unknown instead of unit Add comments; simplify `Aliases` API a bit Revert (most of) "Overhaul Aliases_of_canonical_element; add Alias_set" This reverts the parts of commit 9816841 that have been split off into PRs ocaml#383 and ocaml#386, as well as the Bottom stuff (likely to be unnecessary as we're considering making `Coercion.compose` a total function).
poechsel
pushed a commit
to poechsel/ocaml
that referenced
this pull request
Apr 29, 2021
Print aliases for debug. Various improvements * Use `Coercion.t` rather than `Coercion.t option` in many places * Use `Rec_info.t` again where sensible (in making inlining decisions, for instance), but redefine it as `unit` pending the next phase of `Rec_info` overhaul * Add simple `int` fields to `Coercion.t` for changing recursion depth; this is simpler than what we'll actually need but specific enough that we can test meaningfully (e.g., we can tell whether coercions are composed in the right order) Address a CR Update .depend Overhaul Aliases_of_canonical_element; add Alias_set Also return Bottom from more places (generally anything involved in a meet). Use Rec_info.unknown instead of unit Add comments; simplify `Aliases` API a bit Revert (most of) "Overhaul Aliases_of_canonical_element; add Alias_set" This reverts the parts of commit 9816841 that have been split off into PRs ocaml#383 and ocaml#386, as well as the Bottom stuff (likely to be unnecessary as we're considering making `Coercion.compose` a total function).
poechsel
pushed a commit
to poechsel/ocaml
that referenced
this pull request
May 4, 2021
Print aliases for debug. Various improvements * Use `Coercion.t` rather than `Coercion.t option` in many places * Use `Rec_info.t` again where sensible (in making inlining decisions, for instance), but redefine it as `unit` pending the next phase of `Rec_info` overhaul * Add simple `int` fields to `Coercion.t` for changing recursion depth; this is simpler than what we'll actually need but specific enough that we can test meaningfully (e.g., we can tell whether coercions are composed in the right order) Address a CR Update .depend Overhaul Aliases_of_canonical_element; add Alias_set Also return Bottom from more places (generally anything involved in a meet). Use Rec_info.unknown instead of unit Add comments; simplify `Aliases` API a bit Revert (most of) "Overhaul Aliases_of_canonical_element; add Alias_set" This reverts the parts of commit 9816841 that have been split off into PRs ocaml#383 and ocaml#386, as well as the Bottom stuff (likely to be unnecessary as we're considering making `Coercion.compose` a total function).
chambart
pushed a commit
to chambart/ocaml-1
that referenced
this pull request
Jan 4, 2022
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
* title case fix in up & running * fix top level to toplevel for consistency & to match style guide Signed-off-by: Christine Rose <professor.rose@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies configure scripts so that
-D_ALL_SOURCEis added for AIX.This is needed because some required constants and prototypes are defined
inside
#ifdef _ALL_SOURCEExamples are: