Closed
Conversation
Contributor
|
Nice, but half of those are so useless they would be better removed. |
Contributor
|
Several of those comments are not / no longer useful indeed, but thanks for the translation effort anyway. No idea why CI fails. Assuming the CI failure is spurious, OK for merging. |
Member
Author
|
As far as I understand, the CI Failure was a problem with type_conv 0.113.00 and is unrelated to this patch. |
27d4b54 to
b0e4fa6
Compare
Member
Author
|
I have updated the pull request to solve the merge conflict with the faster test suite commit and corrected some typographical errors. |
Member
|
I'm afraid it was too late, I already merged it in trunk. Would you re-send the typographical fixes? |
Member
Author
|
The typographical fixes are here https://github.com/Octachron/ocaml/tree/french_translation_typo. |
Member
|
Done, thanks. |
mshinwell
pushed a commit
to mshinwell/ocaml
that referenced
this pull request
Aug 25, 2020
* Merge pull request ocaml#9688 from stedolan/main-compiler-libs * Gc.Memprof.start: take a record instead of 5 optional parameters * Try and vendor memtrace * Move memtrace to otherlibs * Add changes to configure * Add a memtrace-enabled ocamlopt as ocamlopt-memtrace * Fix dune build following driver split Co-authored-by: Stephen Dolan <sdolan@janestreet.com> Co-authored-by: Gabriel Scherer <gabriel.scherer@gmail.com>
lthls
pushed a commit
to lthls/ocaml
that referenced
this pull request
Sep 23, 2020
* Merge pull request ocaml#9688 from stedolan/main-compiler-libs * Gc.Memprof.start: take a record instead of 5 optional parameters * Try and vendor memtrace * Move memtrace to otherlibs * Add changes to configure * Add a memtrace-enabled ocamlopt as ocamlopt-memtrace * Fix dune build following driver split Co-authored-by: Stephen Dolan <sdolan@janestreet.com> Co-authored-by: Gabriel Scherer <gabriel.scherer@gmail.com>
lthls
pushed a commit
to lthls/ocaml
that referenced
this pull request
Sep 23, 2020
* Merge pull request ocaml#9688 from stedolan/main-compiler-libs * Gc.Memprof.start: take a record instead of 5 optional parameters * Try and vendor memtrace * Move memtrace to otherlibs * Add changes to configure * Add a memtrace-enabled ocamlopt as ocamlopt-memtrace * Fix dune build following driver split Co-authored-by: Stephen Dolan <sdolan@janestreet.com> Co-authored-by: Gabriel Scherer <gabriel.scherer@gmail.com>
lthls
pushed a commit
to lthls/ocaml
that referenced
this pull request
Sep 24, 2020
* Merge pull request ocaml#9688 from stedolan/main-compiler-libs * Gc.Memprof.start: take a record instead of 5 optional parameters * Try and vendor memtrace * Move memtrace to otherlibs * Add changes to configure * Add a memtrace-enabled ocamlopt as ocamlopt-memtrace * Fix dune build following driver split Co-authored-by: Stephen Dolan <sdolan@janestreet.com> Co-authored-by: Gabriel Scherer <gabriel.scherer@gmail.com>
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
* Add ahrefs to jobs * Fix line breaks in jobs.yml Co-authored-by: Thibaut <thibaut.mattio@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request translates (or deletes in some specific cases) the few remaining french comments in the compiler. I have tried to be as exhaustive as possible and translated all comments that I could detect; in the hope to make the codebase a little more non-french compliant.
The majority of the comments have been translated with the exception of
which have been simply deleted. Note that I would gladly translate the ctype todo if the translation is deemed useful.
To respect the authorship of signed comments, e.g.
(* AAA ... *), I have added the translated text in addition to the unaltered original rather than directly replacing it.( N.B. the translation could definitively be improved/defrenchified )