MPR#7918: fix 4.08+dev regression, object files would remain after build error#2257
Merged
gasche merged 2 commits intoocaml:trunkfrom Feb 26, 2019
Merged
MPR#7918: fix 4.08+dev regression, object files would remain after build error#2257gasche merged 2 commits intoocaml:trunkfrom
gasche merged 2 commits intoocaml:trunkfrom
Conversation
Member
Author
|
Now with a regression test. |
Member
Author
|
I would need a reviewer for this one. @Drup, @alainfrisch, @nojb? |
nojb
approved these changes
Feb 26, 2019
Contributor
nojb
left a comment
There was a problem hiding this comment.
LGTM, modulo a stylistic issue and some check-typo errors.
Member
Author
|
(Testing this on 4.08, and cherry-picking if it works.) |
gasche
added a commit
that referenced
this pull request
Feb 26, 2019
MPR#7918: fix 4.08+dev regression, object files would remain after build error (cherry picked from commit 39f8c80)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MPR#7918.
If approved, this should go into 4.08 -- it's a regression in 4.08+dev.
It would be nice to write a regression test, but I haven't had the time to do so yet.