Closed
Conversation
Member
|
The code looks good. |
Contributor
|
The patch does two things. One is the addition of the column as 3rd argument, as described. The other, as far as I can see, replaces a file number by a file name (literal string) in some places. Why is it correct to do so? Why is it necessary to do so? |
Contributor
Author
|
The diff makes it hard to see what's going on, the labelled arguments are a bit confusing. let emit_debug_info dbg =
- emit_debug_info_gen dbg (fun file_num file_name ->
- emit_string "\t.file\t";
- emit_int file_num; emit_char '\t';
- emit_string_literal file_name; emit_char '\n';
- )
+ emit_debug_info_gen dbg (fun ~file_num ~file_name ->
+ emit_string "\t.file\t";
+ emit_int file_num; emit_char '\t';
+ emit_string_literal file_name; emit_char '\n';
+ )
- (fun file_num line ->
- emit_string "\t.loc\t";
- emit_int file_num; emit_char '\t';
- emit_int line; emit_char '\n')
+ (fun ~file_num ~line ~col:_ ->
+ emit_string "\t.loc\t";
+ emit_int file_num; emit_char '\t';
+ emit_int line; emit_char '\n')The |
Member
|
Merged in trunk. Thanks for the patch. |
Member
|
PR#7226 indicates that this breaks build under clang when Location.none is used, with a negative column value. |
mshinwell
added a commit
to mshinwell/ocaml
that referenced
this pull request
Jul 20, 2020
lthls
pushed a commit
to lthls/ocaml
that referenced
this pull request
Sep 23, 2020
lthls
pushed a commit
to lthls/ocaml
that referenced
this pull request
Sep 23, 2020
lthls
pushed a commit
to lthls/ocaml
that referenced
this pull request
Sep 24, 2020
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
* update "Industrial Users" header to exactly match the Tailwind Playground implementation * also: fix hidden menu issue
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
Co-authored-by: Thibaut Mattio <thibaut.mattio@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU AS supports taking the column as an optional third argument in
.locdirectives.This branch transmits the column to location emitter, and generate the directive on X86 GAS (although it should be supported on other platforms, the generic
Emitaux.emit_debug_infocould be updated too).This result in a minor improvement of DWARF debugging information.